Review Request 121625: Port Kexi Table View to Qt 4

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121625/
-----------------------------------------------------------

Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Finally! A port that took 6 months, now largely functional. Changes are so cross-dependent, it's hard to split to smaller patches that result in something stable.

Changes along the way:
* Harmonize API related to sorting with the Qt API
* Port and clean up current column highlighting
* Make shortcuts work
* Make arrow keys ignore modifiers
* Ensure the current cell is visible before trying to remove current record
* Use separate macro for enabling painting debug
* Use row, then col as args in cellSelected() and paintCell() methods (per convention of Qt)
  This also fixes on ensureCellVisible() call when the args where swapped by mistake.
* If possible don't move pos of current selection after sorting
* Rename record -> row in table view for more generic API
* Clicking on vertical header selects row
* Hovering on vertical header highlights row
* Display current record pointer as icon
* Show mouse highlight in the vertical header when needed
* Support leave event
* Fix sizes and buttons in record navigator
* Make parameter names consistent
* Fix column resizing, column sorting, painting on scroll
* Fix initializing widths of table columns
* Remove unused variable and excessive debug
* Put horizontal scrollbar aside of the record navigator when possible (but don't cover the navigator)

New features:
* Display "key" icon in primary key columns


Diffs
-----


Diff: https://git.reviewboard.kde.org/r/121625/diff/


Testing
-------

Tested on tables and query designer: functional


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141221/e4bc735a/attachment.htm>