Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121598/#review72328
-----------------------------------------------------------


Hi, Rishabh!

Are you sure you want to put the Flatten Layer action into the same group with the actions that create new masks? I guess it would be more logical to put them into the same group with either Flatten Image or Convert To. You could talk to artists to get to find out which way is the most convenient for them.

Another problem is that Flatter Layer action is not getting disabled when a mask is selected. Such behavior is quite ok when the action in the man window menu, but it might be quite unexpected when a user right-clicks on a mask and sees "Flatten Layer", because a mask cannot be flattened. Only it's parent. The easiest approach is to disbale action when a non-layer node is selected. You can follow an example of "Transparency Mask" action. It is also disabled when a maks is selected.

- Dmitry Kazakov


On Dec. 19, 2014, 6:44 p.m., Rishabh Saxena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121598/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 6:44 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Bugs: 331483
>     http://bugs.kde.org/show_bug.cgi?id=331483
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Created a "Flatten layer" option in RightClick context menu using addActiontoMenu() method.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 1a8aabf 
>   krita/plugins/tools/defaulttools/kis_tool_brush.h 16a6acc 
>   krita/plugins/tools/defaulttools/kis_tool_brush.cc a65f618 
> 
> Diff: https://git.reviewboard.kde.org/r/121598/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rishabh Saxena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141220/5b39ab94/attachment.htm>