Review Request 121572: Bug Fix 331791 wish: Add toggle mode or shortcut for brush snap to assistant

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121572/#review72266
-----------------------------------------------------------



krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp
<https://git.reviewboard.kde.org/r/121572/#comment50401>

    The accelerator for a second letter was intentional, because otherwise it conflicts with "Shear", shich is more logical for 'S' accelerator. You can change it for any letter but 'S'.



krita/plugins/tools/defaulttools/kis_tool_brush.cc
<https://git.reviewboard.kde.org/r/121572/#comment50402>

    addAction() accepts the 'id' of the action, which will be use later for accessing it using krita.rc file or via the code that directly fetches the actions from the action collection. This string will never be seen by the user. So it should not be translated. Usually it looks like an c-style valid name:
    
    e.g.:
    
    ```c++
    KAction *increaseBrushSize = new KAction(i18n("Increase Brush Size"), collection);
            increaseBrushSize->setShortcut(Qt::Key_BracketRight);
            collection->addAction("increase_brush_size", increaseBrushSize);
    ```


- Dmitry Kazakov


On Dec. 18, 2014, 7:11 p.m., Rishabh Saxena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121572/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 7:11 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Bugs: 331791
>     http://bugs.kde.org/show_bug.cgi?id=331791
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added a keyboard shortcut for toggling assistant.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/defaulttools/kis_tool_brush.h 16a6acc 
>   krita/plugins/tools/defaulttools/kis_tool_brush.cc a65f618 
> 
> Diff: https://git.reviewboard.kde.org/r/121572/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rishabh Saxena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141218/0369aac5/attachment.htm>