Review Request 121559: Krita - OverviewDockerDock and KisZoomManager fixes

[Stefano Bonicatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121559/
-----------------------------------------------------------

(Updated Dec. 16, 2014, 4:26 p.m.)


Review request for Calligra.


Summary (updated)
-----------------

Krita - OverviewDockerDock and KisZoomManager fixes


Repository: calligra


Description
-------

OverviewDockerDock: no need to call the code in setCanvas if the canvas to be set is the same.

KisZoomManager: the zoom slider widget is created with no parent and then added to a QStatusBar, when it is then removed from it (when an image is closed), it is not deleted because QStatusBar::removeWidget doesn't delete the widget (as Qt Doc says). 
Moreover each time an image is closed KisZoomManager is deleted and then recreated with a new slider when an image is opened. The patch fixes the leak.


Diffs
-----

  krita/plugins/extensions/dockers/overview/overviewdocker_dock.cpp 68bd6fe 
  krita/ui/kis_zoom_manager.cc 50f0e98 

Diff: https://git.reviewboard.kde.org/r/121559/diff/


Testing
-------

Compiles against calligra/2.9.
Doesn't leak anymore.


Thanks,

Stefano Bonicatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141216/53b7fea9/attachment.htm>