Review Request 121541: Qt5/KF5-port assistance by product set system

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121541/#review72112
-----------------------------------------------------------


It looks good to me. I'm not sure it should be applied at the start though -- I'm wondering whether it makes sense to build everything when we're applying Laurent's porting scripts, and then set to unported everything once the mechanical part of porting is done?

- Boudewijn Rempt


On Dec. 15, 2014, 10:15 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121541/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 10:15 p.m.)
> 
> 
> Review request for Calligra, Cyrille Berger Skott, Boudewijn Rempt, and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Before starting the Qt5/KF5 port, apply this patch as the first when having branched off the branch where the port work shall happen. It will help controlling what is build and what not, using all the powers of the product set system.
> No need to uncomment all kind of cmake lines and mess with internal deps, just control by the "UNPORTED" tags.
> 
> It will remove all products/features from the build which have the tag "UNPORTED" in their definition right after the name (at least before the "REQUIRES" section). Initially this patch will set the tag to all products & features, so that the stuff to build after running cmake will be an empty list.
> 
> So once you start working on the port of another product, remove the "UNPORTED" tag for it, so it gets into the list of things to build. To overrule/ignore the "UNPORTED" tags, pass -DBUILD_UNPORTED=1 to cmake.
> 
> Any ideas where this approach could be improved? Tell me, happy to shape things to aid porting efforts some more.
> 
> 
> Diffs
> -----
> 
>   CalligraProducts.cmake 72946c7 
>   cmake/modules/CalligraProductSetMacros.cmake 8b0492b 
> 
> Diff: https://git.reviewboard.kde.org/r/121541/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141216/a932ba00/attachment.htm>