Review Request 121388: Remove rounding for pixels in KoUnit
Boudewijn Rempt
boud at valdyas.org
Mon Dec 8 15:15:36 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121388/#review71563
-----------------------------------------------------------
Ship it!
Ship It!
- Boudewijn Rempt
On Dec. 8, 2014, 1:17 p.m., Dmitry Kazakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121388/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 1:17 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Rounding in KoUnit makes it impossible for a user to position a shape precisely.
>
> I'm not sure why this rounding was added but it seems to be a bit inconsistens with the rest of the KoUnit codedabe. The rest of the functions like ptToUnit() and convertFromUnitToUnit() know nothing about rounding.
>
>
> Diffs
> -----
>
> libs/odf/KoUnit.cpp 191ae0c
> libs/widgets/KoUnitDoubleSpinBox.cpp 9c8af44
>
> Diff: https://git.reviewboard.kde.org/r/121388/diff/
>
>
> Testing
> -------
>
> Tested in Krita
>
>
> Thanks,
>
> Dmitry Kazakov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141208/5271e5f0/attachment.htm>
More information about the calligra-devel
mailing list