Review Request 121388: Remove rounding for pixels in KoUnit

[Dmitry Kazakov]

> On Дек. 8, 2014, 1:32 п.п., Camilla Boemann wrote:
> > as i don't believe anyone but krita uses it i have no objection from global pov.
> > 
> > 
> > but (in krita) are you sure  dialogs that give fractional pixel values makes sense to a user?

It is a good point. But it seems like we don't use KoUnitDoubleSpinBox in Krita directly. Everywhere we use manually crafted spinbox+dropdown combinations. And this control is mostly used in Ko libraries. So this change should be quite safe.


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121388/#review71547
-----------------------------------------------------------


On Дек. 8, 2014, 1:17 п.п., Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121388/
> -----------------------------------------------------------
> 
> (Updated Дек. 8, 2014, 1:17 п.п.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Rounding in KoUnit makes it impossible for a user to position a shape precisely. 
> 
> I'm not sure why this rounding was added but it seems to be a bit inconsistens with the rest of the KoUnit codedabe. The rest of the functions like ptToUnit() and convertFromUnitToUnit() know nothing about rounding.
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoUnit.cpp 191ae0c 
>   libs/widgets/KoUnitDoubleSpinBox.cpp 9c8af44 
> 
> Diff: https://git.reviewboard.kde.org/r/121388/diff/
> 
> 
> Testing
> -------
> 
> Tested in Krita
> 
> 
> Thanks,
> 
> Dmitry Kazakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141208/8d49a974/attachment.htm>