Review Request 120898: Make side panes lighter by removing frames

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120898/
-----------------------------------------------------------

(Updated Dec. 7, 2014, 10:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Make side panes lighter by removing frames

- works in all styles except oxygen
- define a general purpose Close button, use it everywhere (in the docks, pages, message widgets)
- by the way, remove saving position of panes, this fixes right-to-left support

Update: 3rd patch that actually complements the refresh. Feel free to wait for it. The screenshots show Kexi with all the 3 patches applied.


Diffs
-----

  kexi/kexiutils/CMakeLists.txt f04ff0a5c37f6d6ba2de19b4a4c9e78a202d443d 
  kexi/kexiutils/KexiAssistantPage.cpp 6456e8780da5807d5c1b7db150ee1bd02c1b555b 
  kexi/kexiutils/KexiCloseButton.h PRE-CREATION 
  kexi/kexiutils/KexiCloseButton.cpp PRE-CREATION 
  kexi/kexiutils/kmessagewidget.cpp 799730f6442018431be8f1adb226c9ee2cca28b9 
  kexi/kexiutils/styleproxy.h 936232883432cc526b85cb987379c54ec9334d2a 
  kexi/kexiutils/styleproxy.cpp 9381bbc9800af3eb28bb7b5774fe32371bc7b07c 
  kexi/main/KexiMainWindow.cpp 3e0d0fccf10dfea01e3707bca96d84c1e7879dc0 
  kexi/main/KexiMainWindow_p.h fc5b695ab114426da066afa7007ff6a841b27a4f 

Diff: https://git.reviewboard.kde.org/r/120898/diff/


Testing
-------

runs nicely with all the styles as before


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2014/10/29/9b2bae33-bde0-492b-8455-7523265f3729__1.png
Kexi with Oxygen style - maintains frame because the style defines it in a more hardcoded way
  https://git.reviewboard.kde.org/media/uploaded/files/2014/10/30/b9e28598-b52b-4f7b-96fa-30c254016769__1.png
Kexi in Windows style: splitters are visible
  https://git.reviewboard.kde.org/media/uploaded/files/2014/10/30/fabd15f3-00eb-4b83-bd28-b26c2fcce5cc__2.png


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141207/cbbb0f6d/attachment.htm>