Review Request 121226: Krita - Clean global origin workaround

[Damien de Lemeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121226/
-----------------------------------------------------------

(Updated Dec. 7, 2014, 1:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
-------

KisToolProxy::forwardEvent had an ugly workaround parameter to get the origin coordinates of the canvas converted to global coordinates. Better have KisToolProxy creating that origin instead of passing it around.


Diffs
-----

  krita/ui/canvas/kis_tool_proxy.h 307e627 
  krita/ui/canvas/kis_tool_proxy.cpp 0545ea0 
  krita/ui/input/kis_alternate_invocation_action.cpp ce61a84 
  krita/ui/input/kis_change_primary_setting_action.cpp aeade2c 
  krita/ui/input/kis_input_manager.cpp 89919dc 
  krita/ui/input/kis_tool_invocation_action.cpp 33e2640 

Diff: https://git.reviewboard.kde.org/r/121226/diff/


Testing
-------

Compiles OK
Primary tool invocation OK
Alternate tool invocation OK
Change primary settings OK


Thanks,

Damien de Lemeny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141207/8ed66d70/attachment.htm>