Review Request 121281: When printing reports use High DPI

Jarosław Staniek staniek at kde.org
Mon Dec 1 12:08:55 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121281/#review71157
-----------------------------------------------------------


Good, Adam, what is your opinion about this:

Can't we use QPainter::scale() transformation in one place to avoid "* scale" multiplication everywhere?
I thought the QPainter::scale() setting also affects the line width, what's what we want too. Are you willing to experiment?

- Jarosław Staniek


On Nov. 30, 2014, 9:05 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121281/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 9:05 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When printing reports use High DPI
> 
> 
> Diffs
> -----
> 
>   libs/koreport/renderer/KoReportPrintRenderer.cpp 08428520a1e8f8d319069ade7dd4df96dfa2edb3 
>   kexi/plugins/reports/kexireportview.cpp 9c838bc836c9f6c11b6034ea26b9a9b64c3c7acb 
> 
> Diff: https://git.reviewboard.kde.org/r/121281/diff/
> 
> 
> Testing
> -------
> 
> Tested using
> Label (tests OROTextBox)
> Field (tests OROTextBox)
> Check (tests OROCheck)
> Image (tests OROImage)
> Web (tests OROPicture)
> Line (tests OROLine)
> 
> 
> File Attachments
> ----------------
> 
> High resolution print
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/28/909bf09d-c32a-4a46-bb03-790c90a9ad3a__print.pdf
> Old screen resolution PDF
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/28/8e4c5f4f-ee90-4dc4-85b6-4b17ec15e9b9__print_standard.pdf
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141201/aded3542/attachment.htm>


More information about the calligra-devel mailing list