Review Request 120010: Allow to exit text-edit mode by pressing Escape.

Thorsten Zachmann t.zachmann at zagge.de
Sun Aug 31 06:23:46 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120010/#review65568
-----------------------------------------------------------

Ship it!


Looks good to me. Please commit to 2.8 and master.

- Thorsten Zachmann


On Aug. 30, 2014, 9:03 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120010/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 9:03 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This improves the usability of calligrastage tremendously.
> 
> Which branch should I push this to? 2.8? Does it get merged into master or should I?
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/TextTool.cpp 2bf8787816c100dbd7acde8ac730e91676a3ac41 
> 
> Diff: https://git.reviewboard.kde.org/r/120010/diff/
> 
> 
> Testing
> -------
> 
> Esc now works :)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140831/673b0e7f/attachment.htm>


More information about the calligra-devel mailing list