Review Request 119169: Cleanup for report element tag names, use namespaces consistently

Jarosław Staniek staniek at kde.org
Mon Aug 11 20:46:36 BST 2014



> On July 11, 2014, 9:58 p.m., Adam Pigg wrote:
> > Have you tested loading existing reports with all elements?

Yep, and this let me found a bug in map element (fixed in "Properly retrieve map element after saving and re-opening report").


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119169/#review62152
-----------------------------------------------------------


On July 8, 2014, 1:43 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119169/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 1:43 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Cleanup for report element tag names, use namespaces consistently
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportItemMaps.cpp 1f6e7fc865f37a197cba467e433c100d0facaf05 
>   plugins/reporting/maps/KoReportMapsPlugin.cpp 90e42aee6cf3c2629bd74250d38002d7b8ca958c 
>   plugins/reporting/web/KoReportDesignerItemWeb.cpp 63e1cc9a706de0cef5e8555e5e731c70181455ae 
>   plugins/reporting/web/KoReportWebPlugin.cpp d9b4f5cf63f9eb3811bd63c6ff016b369fc2c494 
>   plugins/reporting/maps/KoReportDesignerItemMaps.cpp f624db3192f7801f26944faf997b147569778ef0 
>   plugins/reporting/chart/KoReportChartPlugin.cpp 519c7865bd785c93a602bc63c78c1f4d72ed9ec6 
>   plugins/reporting/chart/KoReportDesignerItemChart.cpp 65ce99b154e70e4a56548568b8ecc283eb306b26 
>   plugins/reporting/barcode/KoReportBarcodePlugin.cpp a2314a80455590f5c5c194731715ae4444946a50 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp b4fb621d5b2bd0dc59afa33f62dc01dd52e9b491 
>   libs/koreport/wrtembed/KoReportDesignerItemLine.cpp 1b0474d1b849d0aad1c3356f1d92f774ac9c98d5 
>   libs/koreport/wrtembed/reportsection.cpp 9992f422939ff145e9a429e126a896861ee6ec7d 
>   libs/koreport/renderer/scripting/krscriptsection.cpp 28b05202f996d40d4ebbca2e583e8fce251f9d49 
>   libs/koreport/common/krsectiondata.cpp ae3c73c7edca6d16a97c71727cdbd8c39bcd761c 
>   libs/koreport/items/check/KoReportCheckPlugin.cpp 906488ca231bcc4d011eecf62f59eb1f075da427 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp 5bebc6c4e10f2243919a0b2668ea3a8ff02ce954 
>   libs/koreport/items/check/KoReportItemCheck.cpp 188d5ab232a31347ca24f91c81411683eb6256c9 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp 0dc9325a1c04dda83bdc7c2a3e4eae5eb500c52f 
>   libs/koreport/items/field/KoReportFieldPlugin.cpp 5ed590b68e0bdca79cac4fbdff7bd02d3e2264fb 
>   libs/koreport/items/field/KoReportItemField.cpp 9b12fe184bf56410ae8af33280eb64e735f36e3d 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp 87e46a1ca3ad6dc0a025eeac90dac12e12029691 
>   libs/koreport/items/image/KoReportImagePlugin.cpp 6de963f6df5f41a02eef6d0b7aa785e0d6987871 
>   libs/koreport/items/image/KoReportItemImage.cpp e1b2965686a607e0739b70f10b11ea63068d4223 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8974a807b122649a6c6daf61f34c678cb5ec9961 
>   libs/koreport/items/label/KoReportItemLabel.cpp 78be96aad00ca8375d0a9c7e1aa7c1dd8e162bee 
>   libs/koreport/items/label/KoReportLabelPlugin.cpp 0eb154a072efd0780488e46c07379e66fa32ed00 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp 51e12d3020104fec4cb8cc473d5499e085dfbf2c 
>   libs/koreport/items/text/KoReportItemText.cpp 2f4703a0c8847a29c41ee4c21b2c58744334b1a6 
>   libs/koreport/items/text/KoReportTextPlugin.cpp db835f8263e18842fe49ca144fa83b08d1deafc5 
>   libs/koreport/renderer/KoReportPreRenderer.cpp a7913fff95bdcef47ddb58c969fbdabb2a9774bc 
>   libs/koreport/renderer/scripting/krscriptreport.cpp 7834c7e744ba9e3723fcbb3d3eaf9d9254a56572 
> 
> Diff: https://git.reviewboard.kde.org/r/119169/diff/
> 
> 
> Testing
> -------
> 
> tested by working with report elements
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140811/0427aa97/attachment.htm>


More information about the calligra-devel mailing list