Review Request 119666: Improve behaviour of tabbed toolbar when Design Tab is present

Jarosław Staniek staniek at kde.org
Mon Aug 11 20:25:20 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119666/
-----------------------------------------------------------

(Updated Aug. 11, 2014, 7:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Improve behaviour when:
* user activates different Kexi (tabbed) window - selected toolbar tab for the previous window is remembered
* user activates different toolbar tab - selected tab will be assigned to the Kexi window
* user opens a new window - previously active window is properly recognized
* user closes a window - tabs are updated properly
* user switched between design/data/text mode - toolbar's tabs are activated properly

In general: activate the Design tab when it makes more sense.

Also: improve naming of methods.


Diffs
-----

  kexi/main/KexiMainWindow_p.h 21bc11caaceb7d6db8d42b1cf448dbf9ebb4e405 
  kexi/main/KexiMainWindow.h da5b806d5e3ce799fb7afb60a5b245f7ad579bcc 
  kexi/main/KexiMainWindow.cpp 1bd327bf515cf0787fd8275c3e9b3904b95124ba 

Diff: https://git.reviewboard.kde.org/r/119666/diff/


Testing
-------

tabs improved


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140811/c5b82d8e/attachment.htm>


More information about the calligra-devel mailing list