Review Request 119609: Animation support in Krita

Somsubhra Bairi somsubhra.bairi at gmail.com
Sat Aug 9 11:06:11 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119609/
-----------------------------------------------------------

(Updated Aug. 9, 2014, 10:06 a.m.)


Review request for Calligra.


Changes
-------

Remove extra layer variable in KisDoc2.


Repository: calligra


Description
-------

Animation support in Krita.
This is a full diff of the 'animator-plugin-somsubhra' branch.


Diffs (updated)
-----

  krita/plugins/extensions/dockers/animator/animator_settings_dialog.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_animation_frame.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_animation_frame.cpp PRE-CREATION 
  krita/ui/kranim/kis_kranim_saver.cpp PRE-CREATION 
  krita/ui/kranim/kis_kranim_tags.h PRE-CREATION 
  krita/ui/kranimstore/kis_animation_store.h PRE-CREATION 
  krita/ui/kranimstore/kis_animation_store.cpp PRE-CREATION 
  krita/ui/kranimstore/kis_animation_store_writer.h PRE-CREATION 
  krita/ui/widgets/kis_animation_selector.h PRE-CREATION 
  krita/ui/kis_config.h 18a80f4 
  krita/ui/kis_config.cc 815fe56 
  krita/ui/kis_doc2.cc a33a0e5 
  krita/ui/kis_onion_skin_loader.h PRE-CREATION 
  krita/ui/kis_onion_skin_loader.cpp PRE-CREATION 
  krita/ui/kranim/kis_kranim_loader.h PRE-CREATION 
  krita/ui/kranim/kis_kranim_loader.cpp PRE-CREATION 
  krita/ui/kranim/kis_kranim_saver.h PRE-CREATION 
  krita/ui/kis_animation_part.h PRE-CREATION 
  krita/ui/kis_animation_part.cpp PRE-CREATION 
  krita/ui/kis_animation_player.h PRE-CREATION 
  krita/ui/kis_animation_player.cpp PRE-CREATION 
  krita/ui/kis_animator_aboutdata.h PRE-CREATION 
  krita/ui/kis_animation.h PRE-CREATION 
  krita/ui/kis_animation.cpp PRE-CREATION 
  krita/ui/kis_animation_doc.h PRE-CREATION 
  krita/ui/kis_animation_doc.cpp PRE-CREATION 
  krita/ui/kis_animation_factory.h PRE-CREATION 
  krita/ui/kis_animation_factory.cpp PRE-CREATION 
  krita/plugins/formats/kranimseq/sequence_generator.h PRE-CREATION 
  krita/plugins/formats/kranimseq/sequence_generator.cpp PRE-CREATION 
  krita/ui/CMakeLists.txt 02a9509 
  krita/ui/forms/wdganimationselector.ui PRE-CREATION 
  krita/plugins/extensions/dockers/animator/onionskin_dock.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/onionskin_dock.cpp PRE-CREATION 
  krita/plugins/formats/CMakeLists.txt defea52 
  krita/plugins/formats/kranimseq/CMakeLists.txt PRE-CREATION 
  krita/plugins/formats/kranimseq/kis_wdg_options_kranimseq.ui PRE-CREATION 
  krita/plugins/formats/kranimseq/kranim_sequence.h PRE-CREATION 
  krita/plugins/formats/kranimseq/kranim_sequence.cpp PRE-CREATION 
  krita/plugins/formats/kranimseq/kranimseq_export.desktop PRE-CREATION 
  krita/ui/widgets/kis_animation_selector.cpp PRE-CREATION 
  libs/main/KoDocument.cpp e452edb 
  krita/plugins/extensions/dockers/animator/kis_frame_box.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_frame_box.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_layer_contents.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_layer_contents.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_opacity_selector.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_opacity_selector.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_opacity_selector_view.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_opacity_selector_view.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_timeline.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_timeline.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_timeline_header.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_timeline_header.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_animation_layer.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_animation_layer.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_animation_layerbox.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/kis_animation_layerbox.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator_settings_dialog.h PRE-CREATION 
  extras/thumbnail/CMakeLists.txt d0dd623 
  extras/thumbnail/kritaanimation_kranim_thumbnail.desktop PRE-CREATION 
  krita/CMakeLists.txt 3668a56 
  krita/animator/CMakeLists.txt PRE-CREATION 
  krita/animator/krita_animationdock.desktop PRE-CREATION 
  krita/animator/kritaanimation.desktop PRE-CREATION 
  krita/animator/kritaanimation.rc PRE-CREATION 
  krita/animator/kritaanimation.xml PRE-CREATION 
  krita/animator/kritaanimation_part_init.cpp PRE-CREATION 
  krita/animator/kritaanimationpart.desktop PRE-CREATION 
  krita/animator/kritaanimationrc PRE-CREATION 
  krita/animator/main.cpp PRE-CREATION 
  krita/data/input/CMakeLists.txt 90c72d1 
  krita/plugins/extensions/dockers/CMakeLists.txt b14831f 
  krita/plugins/extensions/dockers/animator/CMakeLists.txt PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator_dock.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator_dock.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator_playback_dialog.h PRE-CREATION 
  krita/plugins/extensions/dockers/animator/animator_playback_dialog.cpp PRE-CREATION 
  krita/plugins/extensions/dockers/animator/krita_animator.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119609/diff/


Testing
-------

Few things in the layer box of the timeline do not work and cause random crash.


Thanks,

Somsubhra Bairi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140809/451fb5be/attachment.htm>


More information about the calligra-devel mailing list