Review Request 119558: Krita: Add labels for nameless sliders

[Scott Petrovic]

> On Aug. 7, 2014, 7:29 p.m., Boudewijn Rempt wrote:
> > This looks pretty much perfect! Except for one niggle, and I'm not sure about that -- it looks like the actual curve widget is now really small, and the labels sort of disconnect from it. But maybe it always was like that -- check http://www.valdyas.org/~boud/curvewidget.png and tell me whether I'm missing something or not. When I'm sure about that part, ship it!

There is something funky going on with those curve editors in general. I have a screenshot what it looks like in 2.8.3 on my Windows 7 machine.  http://www.scottpetrovic.com/uploads/krita/krita-2.8.3-curve%20editor.jpg  It is slightly different than yours, but it is still pretty small. Some settings areas by the curve editor have different padding, so it looks like it changes the curve editor as well. I think the entire "edit brush settings" need to be re-organized a little bit (along with updating the curve editor). Out of all of the areas in the application, I think that could use the most UI improvements.  I bought that C++ book you mentioned and am tinkering around with the code in general. I think what I have is ok for now. You're the boss though!


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119558/#review64011
-----------------------------------------------------------


On Aug. 1, 2014, 1:54 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119558/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 1:54 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> add labels for nameless sliders
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui d52b2f8 
>   krita/plugins/paintops/libpaintop/forms/wdgautobrush.ui 2f56bc1 
>   krita/plugins/paintops/libpaintop/forms/wdgcurveoption.ui ee8d229 
>   krita/plugins/paintops/libpaintop/kis_curve_option_widget.cpp c3ea0e8 
> 
> Diff: https://git.reviewboard.kde.org/r/119558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140808/7068f1dc/attachment.htm>