Review Request 119611: odb gettablename and gettableschema functions( kexi)

Jarosław Staniek staniek at kde.org
Tue Aug 5 17:58:15 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119611/#review63876
-----------------------------------------------------------


Good. Since I reviewed at [1] without waiting for the code to appear on in calligra.git, please address these notes.

[1] https://github.com/harshitamistry/calligraRepository/commit/3cd06806177806101cbd1663a8b872d1ca94da27

- Jarosław Staniek


On Aug. 5, 2014, 6:19 p.m., harshita mistry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119611/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 6:19 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Adding functions gettablename and gettableschema which gets all table names and schema.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c3bb9fc8b6d4d25bed0895bdd40580573db7cbfa 
>   kexi/migration/CMakeLists.txt 2478b103ce31a561fa716473725655dce8719516 
>   kexi/migration/importwizard.cpp 16c10c2634801e8c3b6168bc9fd4bd734f5f2e4d 
>   kexi/migration/migratemanager.cpp 92a8877b31e388777d1e9b0096f1b83cabb2238a 
>   kexi/migration/odb/CMakeLists.txt PRE-CREATION 
>   kexi/migration/odb/keximigrate_odb.desktop PRE-CREATION 
>   kexi/migration/odb/odbmigrate.h PRE-CREATION 
>   kexi/migration/odb/odbmigrate.cpp PRE-CREATION 
>   kexi/migration/odb/reader/CMakeLists.txt PRE-CREATION 
>   kexi/migration/odb/reader/OdbReader.java PRE-CREATION 
>   kexi/widget/KexiFileWidget.cpp 86e472b5a7f64ba0aba0a6ea30b80616d2d2b99e 
> 
> Diff: https://git.reviewboard.kde.org/r/119611/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> harshita mistry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140805/e4100fa2/attachment.htm>


More information about the calligra-devel mailing list