Review Request 117709: Make setting solid and inherited background color possible in Kexi form widgets

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117709/#review56791
-----------------------------------------------------------

Ship it!


Ship It!

- Adam Pigg


On April 23, 2014, 4:01 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117709/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 4:01 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Bugs: 333548 and 333549
>     http://bugs.kde.org/show_bug.cgi?id=333548
>     http://bugs.kde.org/show_bug.cgi?id=333549
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Make setting solid and inherited background color possible in form widgets. "autoFillBackgound" has been property re-enabled for this; it's set to true when user selects background color.
> 
> This patch also contains bits for reloading the property set what's handy for the affected properties but not critical. More investigation on another level is needed to finish this.
> 
> "autoFillBackgound" is not i18n'd but not a big deal - this will be added for 2.9.0.
> 
> A fix for 2.8.3: it's better to have it now and allow users to properly format their forms earlier than later.
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/form.cpp efdd2309ec76494014e8d096f16d5783195a5b29 
>   kexi/formeditor/formIO.cpp e307c843c2f485d43eb4777200fec2e4a2ec6c91 
>   kexi/formeditor/widgetlibrary.cpp e0b34c4815ee44002ebccd889f1f48abda739f13 
>   kexi/plugins/forms/kexidbfactory.h a8b2a7e5dca2b2484bac03eab0d28d7a780c3e59 
>   kexi/plugins/forms/kexidbfactory.cpp 94786a006fb6d6def32b43b28ca048811bd00a82 
> 
> Diff: https://git.reviewboard.kde.org/r/117709/diff/
> 
> 
> Testing
> -------
> 
> Forms with colorful labels/frames work, changes save/load OK
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140428/5cc4dc25/attachment.htm>