Review Request 117797: Fix for Kexi crash in DebugGUI mode

Jarosław Staniek staniek at kde.org
Mon Apr 28 00:16:15 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117797/#review56698
-----------------------------------------------------------



kexi/kexiutils/debuggui.cpp
<https://git.reviewboard.kde.org/r/117797/#comment39552>

    Ah, -1 here too



kexi/kexiutils/debuggui.cpp
<https://git.reviewboard.kde.org/r/117797/#comment39553>

    Almost works but I found out that the 1st arg (parent) is 0 when lastItem is at the highest level. So if it's 0, kexiAlterTableActionDebugPage->invisibleRootItem() should be used as parent.


- Jarosław Staniek


On April 27, 2014, 9:25 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117797/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 9:25 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 333933
>     http://bugs.kde.org/show_bug.cgi?id=333933
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch adds additional check if there is no null pointer. If so first item is created
> 
> 
> Diffs
> -----
> 
>   kexi/kexiutils/debuggui.cpp fb22bfb 
> 
> Diff: https://git.reviewboard.kde.org/r/117797/diff/
> 
> 
> Testing
> -------
> 
> Kexi stopped to crashed in DebugGUI mode
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140427/bd199ff4/attachment.htm>


More information about the calligra-devel mailing list