Review Request 117759: Do not crash when Kexi is unable to find plugins; display message and exit

[Adam Pigg]

On Fri, Apr 25, 2014 at 7:39 PM, Jarosław Staniek <staniek at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117759/
>
> On April 25th, 2014, 5:56 p.m. UTC, *Adam Pigg* wrote:
>
>   kexi/core/kexipartmanager.cpp<https://git.reviewboard.kde.org/r/117759/diff/1/?file=268132#file268132line107> (Diff
> revision 1)
>
> Manager::Manager(QObject *parent)
>
>   101
>
>                        "Missing or invalid default <application>%1</application> configuration (no <resource>%2</resource> key). "
>
> 107
>
>                                  "Missing or invalid default application's configuration. No <resource>%1</resource> key.",
>
>   I would say:
> Missing of invalid default application configuration. ....
>
>  Missing of?
> Or Missing *or* ? :)
>
>
> Yada yada .. just remove the 's ;)

> - Jarosław
>
> On April 24th, 2014, 10:26 p.m. UTC, Jarosław Staniek wrote:
>   Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk,
> Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> By Jarosław Staniek.
>
> *Updated April 24, 2014, 10:26 p.m.*
>  *Repository: * calligra
> Description
>
> Do not crash when Kexi is unable to find plugins; display message and exit
>
> Also try to build sycoca
>
>   Testing
>
> No longer crashes in environment without KDEDIRS set
>
>   Diffs
>
>    - kexi/core/kexipart.cpp (442ce84bb02b88ca1d031dbf8b30ac0b41698bd9)
>    - kexi/core/kexipartinfo.h (bd1c892588831a8e21bb3e88c6a53d584cf6e343)
>    - kexi/core/kexipartinfo.cpp (912c8c1eedc6741322fcd7261fca3d28bf45dc2f)
>    - kexi/core/kexipartmanager.cpp
>    (6954cffa89a1188452d038c5fb508776b2c9ec28)
>    - kexi/main/KexiMainWindow.cpp
>    (285c3e7d4ecc5242c2678687e5fbe4508bf6cb1f)
>    - kexi/main/startup/KexiStartup.h
>    (57eb953c88c2491dbfa3484d94cf49fd7a17d553)
>    - kexi/main/startup/KexiStartup.cpp
>    (252510c105cd1336e50bc14ac5cdc2653a813fb4)
>
> View Diff <https://git.reviewboard.kde.org/r/117759/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140425/f9791b90/attachment.htm>