Review Request 117666: Implement Polarize filter for Krita.

Sven Langkamp sven.langkamp at gmail.com
Wed Apr 23 11:47:21 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117666/#review56153
-----------------------------------------------------------


Code looks good and the filter works. There are a few unneeded includes.

Nice work.


krita/plugins/filters/posterize/posterize.cpp
<https://git.reviewboard.kde.org/r/117666/#comment39178>

    Should use torgba16 here.


- Sven Langkamp


On April 20, 2014, 7:59 p.m., Manuel Riecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117666/
> -----------------------------------------------------------
> 
> (Updated April 20, 2014, 7:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Can be found in "Artistic/Posterize...", does the same as the GIMP filter by the same name: http://gimp.cp-dev.com/manual/gimp-tool-posterize.html
> 
> 
> Diffs
> -----
> 
>   krita/plugins/filters/CMakeLists.txt 31fbc8c251d99f9df8113fb088b3f77c164e1466 
>   krita/plugins/filters/posterize/CMakeLists.txt PRE-CREATION 
>   krita/plugins/filters/posterize/kritaposterize.desktop PRE-CREATION 
>   krita/plugins/filters/posterize/posterize.h PRE-CREATION 
>   krita/plugins/filters/posterize/posterize.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manuel Riecke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140423/b853e55c/attachment.htm>


More information about the calligra-devel mailing list