Review Request 117687: Port Kexi Forms to Qt4's scroll area

Jarosław Staniek staniek at kde.org
Wed Apr 23 10:38:57 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117687/
-----------------------------------------------------------

(Updated April 23, 2014, 9:38 a.m.)


Review request for Calligra, Andrius da Costa Ribas, Inge Wallin, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.


Changes
-------

- hide horizontal scrolbar when it's not needed and record navigator isn't visible


Repository: calligra


Description
-------

Port Kexi Forms to Qt4's scroll area from Qt3's Scroll View. This is a milestone leading to Qt5-based Kexi. 

- Removed KexiScrollView which was a complex and not widely used generalization of KexiFormScrollView. Removed functionality goes to KexiFormScrollView.
- Temporarily wrapped TableView in order to keep it functional.

Porting TableView will go next.


Diffs (updated)
-----

  kexi/core/KexiRecordNavigatorIface.h bb0c13f 
  kexi/formeditor/commands.cpp 4a90ab5 
  kexi/formeditor/container.cpp 54a6a83 
  kexi/formeditor/form.h 3dbbe27 
  kexi/formeditor/form.cpp ee92e84 
  kexi/formeditor/resizehandle.cpp b503261 
  kexi/plugins/forms/CMakeLists.txt 972456d 
  kexi/plugins/forms/KexiFormScrollAreaWidget.h PRE-CREATION 
  kexi/plugins/forms/KexiFormScrollAreaWidget.cpp PRE-CREATION 
  kexi/plugins/forms/kexiformpart.h 8d670bd 
  kexi/plugins/forms/kexiformpart.cpp 0cfa59e 
  kexi/plugins/forms/kexiformscrollview.h fac7607 
  kexi/plugins/forms/kexiformscrollview.cpp d6120cf 
  kexi/plugins/forms/kexiformview.h a58de5e 
  kexi/plugins/forms/kexiformview.cpp 5cf7053 
  kexi/plugins/forms/widgets/kexidbform.h 78da955 
  kexi/plugins/forms/widgets/kexidbform.cpp 7c6f49c 
  kexi/widget/CMakeLists.txt cf6be39 
  kexi/widget/kexiscrollview.h 7c5cc13 
  kexi/widget/kexiscrollview.cpp f175f40 
  kexi/widget/tableview/kexitableview.cpp 2120117 
  kexi/widget/utils/kexirecordnavigator.h afc255e 
  kexi/widget/utils/kexirecordnavigator.cpp 5400578 

Diff: https://git.reviewboard.kde.org/r/117687/diff/


Testing
-------

Form and Table views work as before


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140423/012205a2/attachment.htm>


More information about the calligra-devel mailing list