Review Request 117626: Implement the first version of a DOCX export filter

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117626/
-----------------------------------------------------------

(Updated April 22, 2014, 6:14 a.m.)


Review request for Calligra.


Changes
-------

Version 3. All issues fixed except 1 or 2 that were out of scope for this patch.


Repository: calligra


Description
-------

This patch implements the first simple version of a docx export filter. It has support for simple character formatting and paragraph formatting, including named styles. It can also distinguish between headings and normal paragraphs. Other than that it's an unwritten page.  A special thanks to Lassi Nieminen who helped me with converting the styles.

The patch itself is very straightforward and mostly self contained in the filters/words/docx subdirectory. It builds on my previous work with libodfreader and libodf2, which are both in filters/. The only problem was that the KoZipStore and KoEncryptedStore backends create a file called "mimetype" automatically when a KoStore is created in write mode. I tried to work around this with as little impact as possible to the code in libs/odf and with full source compatibility with the previous API. If you think there is a better way to solve this problem than the one I implemented, then please tell me.


Diffs (updated)
-----

  CMakeLists.txt 9eedc3d 
  filters/libodf2/KoOdfStyle.h 558ade9 
  filters/libodf2/KoOdfStyle.cpp 2b4eb95 
  filters/libodf2/KoOdfStyleManager.h 3761d38 
  filters/libodf2/KoOdfStyleManager.cpp 6e8f5b55 
  filters/libodf2/KoOdfStyleProperties.h 1bfbb5c 
  filters/libodf2/KoOdfStyleProperties.cpp 186e971 
  filters/libodfreader/OdtReader.h 64e0584 
  filters/libodfreader/OdtReader.cpp 6fa8ce6 
  filters/words/docx/CMakeLists.txt f38a2bb 
  filters/words/docx/export/CMakeLists.txt PRE-CREATION 
  filters/words/docx/export/DocxExport.h PRE-CREATION 
  filters/words/docx/export/DocxExport.cpp PRE-CREATION 
  filters/words/docx/export/DocxFile.h PRE-CREATION 
  filters/words/docx/export/DocxFile.cpp PRE-CREATION 
  filters/words/docx/export/DocxStyleHelper.h PRE-CREATION 
  filters/words/docx/export/DocxStyleHelper.cpp PRE-CREATION 
  filters/words/docx/export/DocxStyleWriter.h PRE-CREATION 
  filters/words/docx/export/DocxStyleWriter.cpp PRE-CREATION 
  filters/words/docx/export/FileCollector.h PRE-CREATION 
  filters/words/docx/export/FileCollector.cpp PRE-CREATION 
  filters/words/docx/export/OdfReaderDocxContext.h PRE-CREATION 
  filters/words/docx/export/OdfReaderDocxContext.cpp PRE-CREATION 
  filters/words/docx/export/OdfTextReaderDocxBackend.h PRE-CREATION 
  filters/words/docx/export/OdfTextReaderDocxBackend.cpp PRE-CREATION 
  filters/words/docx/export/OdtReaderDocxBackend.h PRE-CREATION 
  filters/words/docx/export/OdtReaderDocxBackend.cpp PRE-CREATION 
  filters/words/docx/export/OpcContentTypes.h PRE-CREATION 
  filters/words/docx/export/OpcContentTypes.cpp PRE-CREATION 
  filters/words/docx/export/OpcRelSet.h PRE-CREATION 
  filters/words/docx/export/OpcRelSet.cpp PRE-CREATION 
  filters/words/docx/export/OpcRelSetManager.h PRE-CREATION 
  filters/words/docx/export/OpcRelSetManager.cpp PRE-CREATION 
  filters/words/docx/export/README PRE-CREATION 
  filters/words/docx/export/UnitConversions.h PRE-CREATION 
  filters/words/docx/export/UnitConversions.cpp PRE-CREATION 
  filters/words/docx/export/calligra_filter_odt2docx.desktop PRE-CREATION 
  libs/odf/KoDirectoryStore.h 19c059d 
  libs/odf/KoDirectoryStore.cpp c893d47 
  libs/odf/KoEncryptedStore.h 0edd892 
  libs/odf/KoEncryptedStore.cpp 315df1a 
  libs/odf/KoStore.h dadecd1 
  libs/odf/KoStore.cpp fd42378 
  libs/odf/KoStore_p.h 2e518c1 
  libs/odf/KoTarStore.h d99f09b 
  libs/odf/KoTarStore.cpp 6829f34 
  libs/odf/KoZipStore.h 90ffcb0 
  libs/odf/KoZipStore.cpp 4235134 

Diff: https://git.reviewboard.kde.org/r/117626/diff/


Testing
-------

Testing with a number of odt files. Lassi did all the testing involving MS Office since I don't have that.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140422/d0225a95/attachment.htm>