Review Request 116533: Bug 142563

Inge Wallin inge at lysator.liu.se
Fri Apr 11 05:39:37 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116533/#review55424
-----------------------------------------------------------



sheets/functions/math.xml
<https://git.reviewboard.kde.org/r/116533/#comment38582>

    I'm not sure this text is an improvement. For one thing, it's not "greater than" if the number is already an integer.
    
    So at least it should be "...returns the smallest number equal to or greater than the input number" (notice that you shouldn't omit the "the").
    
    But actually I think "smallest integer" is better so I like the original text.


- Inge Wallin


On March 2, 2014, 3:12 p.m., Swarn Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116533/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 3:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 142563
>     http://bugs.kde.org/show_bug.cgi?id=142563
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Corrected definition of functions and their corresponding related functions.
> 
> 
> Diffs
> -----
> 
>   sheets/functions/math.xml 5b47291 
> 
> Diff: https://git.reviewboard.kde.org/r/116533/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Swarn Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140411/7bb8dee5/attachment.htm>


More information about the calligra-devel mailing list