Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112883/
-----------------------------------------------------------

(Updated Sept. 22, 2013, 1:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and Boudewijn Rempt.


Description
-------

On AMD graphic cards the Krita OpengGL 2 branch shows some flickering. The problem happens when only a part of the widget is updated e.g. when switching between menu.

The patch solves that by dropping paint events that update that have an update rect smaller than the size of the widget. In that case a new update with the full size of the widget is trigger.

It's somewhat of an ugly hack, but it's the best solution that I could find. Better suggestions appreciated.


This addresses bug 322808.
    http://bugs.kde.org/show_bug.cgi?id=322808


Diffs
-----

  krita/ui/opengl/kis_opengl_canvas2.h 5d701d6 
  krita/ui/opengl/kis_opengl_canvas2.cpp 2ddd503 

Diff: http://git.reviewboard.kde.org/r/112883/diff/


Testing
-------

Tested on my ATI card. Flickering is gone.


Thanks,

Sven Langkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130922/20ef2465/attachment.htm>