Review Request 111787: Page Layout improvements for Words

[Jérémy BOURDIOL]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111787/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 6:59 p.m.)


Review request for Calligra.


Changes
-------

Fixing some of inge's issues, still some to fix + fix warnings if possible


Description
-------

Huge feature on page layout started a moment ago.

PageLayout improvement now allows users to :
- resize margins directly with the mouse (still in debug)
- resize page borders directly with the mouse (still in debug)
- switch from portrait to landscape (and vise-versa) with one movement (vertical drag)
- add and remove header/footer with a simple double-click in the corresponding half of the page
- all changes could be see in the page layout dialog (in "page layout" section)

The feature has still some problems (most of them graphical) in extrem uses, please checkout the branch and give your feelings.


Diffs (updated)
-----

  libs/widgets/KoPageLayoutDialog.h 7b0d029 
  libs/widgets/KoPageLayoutWidget.cpp fd3667b 
  words/part/CMakeLists.txt 4e2650c 
  words/part/KWView.h 517cbc1 
  words/part/KWView.cpp 48265fd 
  words/part/author/CAuView.cpp 0c21610 
  words/part/dialogs/KWPageSettingsDialog.h 30a25d3 
  words/part/dialogs/KWPageSettingsDialog.cpp e046ac6 
  words/part/pagetool/KWPageTool.h 45ad7d5 
  words/part/pagetool/KWPageTool.cpp 7935390 
  words/part/pagetool/SimpleHeaderFooterWidget.h 981d917 
  words/part/pagetool/SimpleHeaderFooterWidget.cpp 75b4409 
  words/part/pagetool/SimplePageStyleWidget.h PRE-CREATION 
  words/part/pagetool/SimplePageStyleWidget.cpp PRE-CREATION 
  words/part/pagetool/SimplePageStyleWidget.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111787/diff/


Testing
-------

A lot of manual tests.

known bug :
When resizing the page and the cursor is passing over the previous/next page a double textarea appears


Thanks,

Jérémy BOURDIOL

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130909/2791ea7f/attachment.htm>