Review Request 112573: fix support for thumbnailer & Co.

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112573/#review39517
-----------------------------------------------------------


Hi,

If the patch works, I'd say, push it, but I'm not convinced it's the right thing -- I actually think I solved that problem in the mvc branch already and in a different way, but I need some serious concentration time to get back into that code again, which might take a week or so!

- Boudewijn Rempt


On Sept. 7, 2013, 12:59 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112573/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2013, 12:59 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> 9611fc67fa4e4dca4d151a3e9c801bbb9ce72c90 was done under the assumption that KoParts are now only used in the respective applications.
> But that missed a few cases, grepping for createKoPart lists those:
> * thumbnailer
> * Okular ODP plugin
> * calligraconverter
> 
> The attached patch tries to fix that by not simply using the appname in KoServiceProvider::readNativeService(), but demanding that the component is passed. That way each place which uses KoServiceProvider can precisely define what context should be used.
> 
> Not perfect, perhaps an issue for the Qt5 port?
> 
> But at least it seems to fix the problem with the thumbnailer for me: now when it tries to generate the KoPart to render the thumbnail no longer the assert in KoServiceProvider is hit and I get thumbnails rendered again for all kind of documents we support, including kra and ora files.
> And the apps seem to still work as before.
> 
> Not sure about the solution with KisDlgFileLayer, for most simple code changes I just passed the view as another member, instead of e.g. creating the mimefilterlist callee side. Left to decide for you, Boud, what best to do there.
> 
> 
> This addresses bug 323489.
>     http://bugs.kde.org/show_bug.cgi?id=323489
> 
> 
> Diffs
> -----
> 
>   libs/main/KoVersionDialog.cpp 2f38510 
>   libs/main/KoServiceProvider.cpp e6ab77c 
>   libs/main/KoPart.cpp 56e27b5 
>   libs/main/KoServiceProvider.h 35ca3ac 
>   libs/main/KoMainWindow.cpp 26327aa 
>   libs/main/KoDocument.cpp 622678f 
>   libs/main/KoApplication.cpp 7421107 
>   libs/kopageapp/KoPAView.cpp 2e6400c 
>   krita/ui/widgets/KisFlipbookSelector.cpp 09425fb 
>   krita/ui/dialogs/kis_dlg_file_layer.cpp 46abb0a 
>   krita/ui/dialogs/kis_dlg_file_layer.h cb4dbe0 
>   krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp 49cf62a 
> 
> Diff: http://git.reviewboard.kde.org/r/112573/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130907/ff939903/attachment.htm>