Review Request 113327: Merge Sketch/Gemini to master

Thorsten Zachmann t.zachmann at zagge.de
Sat Oct 19 05:17:25 BST 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113327/#review41970
-----------------------------------------------------------


The flake changes looks sensible to me.


krita/sketch/qml/components/BusyIndicator.qml
<http://git.reviewboard.kde.org/r/113327/#comment30611>

    Can't the Item be removed and just use the image from within at its place. This will reduces on unneeded item. And the less items there are the better



krita/sketch/qml/components/Button.qml
<http://git.reviewboard.kde.org/r/113327/#comment30612>

    The Rectangle fill should replace the Item. The item is not needed.



libs/flake/KoCanvasControllerWidget.h
<http://git.reviewboard.kde.org/r/113327/#comment30613>

    What is the reason to use a subclass here? Can't the base class QAbstractScrollArea be used?



libs/flake/KoToolProxy.h
<http://git.reviewboard.kde.org/r/113327/#comment30614>

    This line should be removed again as it moves the comment away from the function.



libs/flake/tests/TestSnapStrategy.h
<http://git.reviewboard.kde.org/r/113327/#comment30615>

    Using Hanna Skott <hanna.et.scott at gmail.com> as author would be more correct.



libs/flake/tests/TestSnapStrategy.cpp
<http://git.reviewboard.kde.org/r/113327/#comment30616>

    Maybe also add Hanna Skott <hanna.et.scott at gmail.com>
    
    which did the base work on the files



libs/main/KoDocument.h
<http://git.reviewboard.kde.org/r/113327/#comment30617>

    This seems a bit sporty but I guess there is no other way?



libs/main/KoMainWindow.h
<http://git.reviewboard.kde.org/r/113327/#comment30618>

    how about moving this line up into the public area instead of changing it for one line?



libs/main/KoMainWindow.cpp
<http://git.reviewboard.kde.org/r/113327/#comment30619>

    maybe inititalize noCleanup with false as it is a bool and false makes that more clear.



libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/113327/#comment30620>

    this should be a kDebug


- Thorsten Zachmann


On Oct. 18, 2013, 10:47 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113327/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 10:47 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This diff adds Krita Sketch/Gemini to git master. It differs from the old sketch/sketchgl branch in that the DeviantArt plugin isn't included, because of problems with oAuth2's handling of secrets, and the move of the jpeg converter is reverted.
> 
> The krita-gemini-rempt branch contains the same diff, but sequences in some commits that might make checking what's going on easier than this monster diff.
> 
> There are the following components to this diff:
> 
> * In a lot of places, there is now a label added to the progress updaters.
> * Touch support is added to flake, Krita and Karbon. Pinch zoom/pan works now
> * With the right version of Vc, AVX2 is used where possible.
> * There are getters/setters for Krita's tools
> * KisConfig is cleaned up
> * and, of course, add the kritasketch library and the sketch and gemini binaries.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 41d8ad6 
>   karbon/ui/widgets/KarbonCanvas.cpp 03c8d19 
>   krita/CMakeLists.txt 50465f2 
>   krita/data/CMakeLists.txt 2cb0430 
>   krita/data/brushes/CMakeLists.txt b2fcb64 
>   krita/data/input/CMakeLists.txt 65bbaad 
>   krita/data/input/kritadefault.profile 53f4cdc 
>   krita/data/paintoppresets/CMakeLists.txt a2bc5af 
>   krita/data/patterns/3-flat-hack.png PRE-CREATION 
>   krita/data/patterns/3-mini-rock-soft.png PRE-CREATION 
>   krita/data/patterns/3-rock-smooth.png PRE-CREATION 
>   krita/data/patterns/CMakeLists.txt b4bd108 
>   krita/gemini/CMakeLists.txt PRE-CREATION 
>   krita/gemini/KritaGemini.rc PRE-CREATION 
>   krita/gemini/MainWindow.h PRE-CREATION 
>   krita/gemini/MainWindow.cpp PRE-CREATION 
>   krita/gemini/ViewModeSwitchEvent.h PRE-CREATION 
>   krita/gemini/desktopviewproxy.h PRE-CREATION 
>   krita/gemini/desktopviewproxy.cpp PRE-CREATION 
>   krita/gemini/kritagemini.desktop PRE-CREATION 
>   krita/gemini/kritagemini.qml PRE-CREATION 
>   krita/gemini/kritageminipanelsrc PRE-CREATION 
>   krita/gemini/kritageminirc PRE-CREATION 
>   krita/gemini/main.cpp PRE-CREATION 
>   krita/image/commands/kis_set_global_selection_command.cpp d806cd6 
>   krita/image/kis_default_bounds.h 7581166 
>   krita/image/kis_default_bounds.cpp acfc858 
>   krita/image/kis_distance_information.cpp 849c385 
>   krita/image/kis_global.h c9c5d3b 
>   krita/image/kis_image.h a6d9b24 
>   krita/image/kis_image.cc 87eea63 
>   krita/image/kis_processing_visitor.cpp 5761544 
>   krita/image/krita_export.h 6236f7e 
>   krita/image/recorder/kis_macro_player.cc 6da2de0 
>   krita/image/recorder/kis_recorded_node_action.cc 455c82e 
>   krita/image/tests/kis_filter_weights_buffer_test.cpp 6e2401a 
>   krita/image/tests/kis_fixed_point_maths_test.cpp ef1f312 
>   krita/main.cc 9b7e5c1 
>   krita/pics/CMakeLists.txt 0cabd5f 
>   krita/pics/icon-kritasketch.svg PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 00ce7ff 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc 267a011 
>   krita/plugins/extensions/bigbrother/bigbrother.cc 5ba4ac5 
>   krita/plugins/extensions/dropshadow/kis_dropshadow_plugin.cc 0722c3e 
>   krita/plugins/filters/unsharp/kis_unsharp_filter.cpp 1226d24 
>   krita/plugins/tools/defaulttools/CMakeLists.txt 8d7de6f9 
>   krita/plugins/tools/defaulttools/kis_tool_brush.h d40ba4a 
>   krita/plugins/tools/defaulttools/kis_tool_brush.cc a652bea 
>   krita/plugins/tools/defaulttools/kis_tool_colorpicker.h dab13f6 
>   krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc 0c4c876 
>   krita/plugins/tools/defaulttools/kis_tool_move.h a3f08fd 
>   krita/plugins/tools/defaulttools/kis_tool_move.cc 88d0611 
>   krita/plugins/tools/defaulttools/kis_tool_movetooloptionswidget.h PRE-CREATION 
>   krita/plugins/tools/defaulttools/kis_tool_movetooloptionswidget.cpp PRE-CREATION 
>   krita/plugins/tools/selectiontools/kis_tool_select_elliptical.cc e31fd15 
>   krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h cdfc0f6 
>   krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc 34bb54c 
>   krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h b826bba 
>   krita/plugins/tools/selectiontools/kis_tool_select_rectangular.cc 66d3215 
>   krita/plugins/tools/tool_crop/CMakeLists.txt e84978d 
>   krita/plugins/tools/tool_crop/kis_tool_crop.h ba0427d 
>   krita/plugins/tools/tool_crop/kis_tool_crop.cc acbc48d 
>   krita/plugins/tools/tool_crop/kistoolcropconfigwidget.h PRE-CREATION 
>   krita/plugins/tools/tool_crop/kistoolcropconfigwidget.cpp PRE-CREATION 
>   krita/plugins/tools/tool_transform2/kis_tool_transform.h 1f7548e 
>   krita/plugins/tools/tool_transform2/kis_tool_transform.cc 9a17fdb 
>   krita/plugins/tools/tool_transform2/kis_tool_transform_config_widget.h 5b7f932 
>   krita/plugins/tools/tool_transform2/tool_transform.cc 9372cfd 
>   krita/plugins/tools/tool_transform2/tool_transform_args.h 8e5befd 
>   krita/sketch/CMakeLists.txt PRE-CREATION 
>   krita/sketch/ColorSelectorItem.h PRE-CREATION 
>   krita/sketch/ColorSelectorItem.cpp PRE-CREATION 
>   krita/sketch/Constants.h PRE-CREATION 
>   krita/sketch/Constants.cpp PRE-CREATION 
>   krita/sketch/DocumentListModel.h PRE-CREATION 
>   krita/sketch/DocumentListModel.cpp PRE-CREATION 
>   krita/sketch/DocumentManager.h PRE-CREATION 
>   krita/sketch/DocumentManager.cpp PRE-CREATION 
>   krita/sketch/ImageBuilder.h PRE-CREATION 
>   krita/sketch/ImageBuilder.cpp PRE-CREATION 
>   krita/sketch/KisSelectionExtras.h PRE-CREATION 
>   krita/sketch/KisSelectionExtras.cpp PRE-CREATION 
>   krita/sketch/KisSketchPart.h PRE-CREATION 
>   krita/sketch/KisSketchPart.cpp PRE-CREATION 
>   krita/sketch/KisSketchView.h PRE-CREATION 
>   krita/sketch/KisSketchView.cpp PRE-CREATION 
>   krita/sketch/KritaNamespace.h PRE-CREATION 
>   krita/sketch/KritaNamespace.cpp PRE-CREATION 
>   krita/sketch/KritaSketch.rc PRE-CREATION 
>   krita/sketch/MainWindow.h PRE-CREATION 
>   krita/sketch/MainWindow.cpp PRE-CREATION 
>   krita/sketch/MouseTracker.h PRE-CREATION 
>   krita/sketch/MouseTracker.cpp PRE-CREATION 
>   krita/sketch/NetworkAccessManager.h PRE-CREATION 
>   krita/sketch/NetworkAccessManager.cpp PRE-CREATION 
>   krita/sketch/PageThumbnailProvider.h PRE-CREATION 
>   krita/sketch/PageThumbnailProvider.cpp PRE-CREATION 
>   krita/sketch/PanelConfiguration.h PRE-CREATION 
>   krita/sketch/PanelConfiguration.cpp PRE-CREATION 
>   krita/sketch/ProgressProxy.h PRE-CREATION 
>   krita/sketch/ProgressProxy.cpp PRE-CREATION 
>   krita/sketch/PropertyContainer.h PRE-CREATION 
>   krita/sketch/PropertyContainer.cpp PRE-CREATION 
>   krita/sketch/RecentFileManager.h PRE-CREATION 
>   krita/sketch/RecentFileManager.cpp PRE-CREATION 
>   krita/sketch/Settings.h PRE-CREATION 
>   krita/sketch/Settings.cpp PRE-CREATION 
>   krita/sketch/SimpleTouchArea.h PRE-CREATION 
>   krita/sketch/SimpleTouchArea.cpp PRE-CREATION 
>   krita/sketch/SketchDeclarativeView.h PRE-CREATION 
>   krita/sketch/SketchDeclarativeView.cpp PRE-CREATION 
>   krita/sketch/SketchInputContext.h PRE-CREATION 
>   krita/sketch/SketchInputContext.cpp PRE-CREATION 
>   krita/sketch/ToolManager.h PRE-CREATION 
>   krita/sketch/ToolManager.cpp PRE-CREATION 
>   krita/sketch/VirtualKeyboardController.h PRE-CREATION 
>   krita/sketch/VirtualKeyboardController.cpp PRE-CREATION 
>   krita/sketch/cpuid.h PRE-CREATION 
>   krita/sketch/cpuid.cpp PRE-CREATION 
>   krita/sketch/draganddrop/CMakeLists.txt PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeDragArea.h PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeDragArea.cpp PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeDragDropEvent.h PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeDragDropEvent.cpp PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeDropArea.h PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeDropArea.cpp PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeMimeData.h PRE-CREATION 
>   krita/sketch/draganddrop/DeclarativeMimeData.cpp PRE-CREATION 
>   krita/sketch/draganddrop/draganddropplugin.h PRE-CREATION 
>   krita/sketch/draganddrop/draganddropplugin.cpp PRE-CREATION 
>   krita/sketch/draganddrop/qmldir PRE-CREATION 
>   krita/sketch/kritasketch.desktop PRE-CREATION 
>   krita/sketch/kritasketch.qml PRE-CREATION 
>   krita/sketch/kritasketchpanelsrc PRE-CREATION 
>   krita/sketch/kritasketchplugin.h PRE-CREATION 
>   krita/sketch/kritasketchplugin.cpp PRE-CREATION 
>   krita/sketch/kritasketchrc PRE-CREATION 
>   krita/sketch/kritatouch.desktop PRE-CREATION 
>   krita/sketch/main.cpp PRE-CREATION 
>   krita/sketch/models/ColorImageProvider.h PRE-CREATION 
>   krita/sketch/models/ColorImageProvider.cpp PRE-CREATION 
>   krita/sketch/models/CompositeOpModel.h PRE-CREATION 
>   krita/sketch/models/CompositeOpModel.cpp PRE-CREATION 
>   krita/sketch/models/FileSystemModel.h PRE-CREATION 
>   krita/sketch/models/FileSystemModel.cpp PRE-CREATION 
>   krita/sketch/models/FiltersCategoryModel.h PRE-CREATION 
>   krita/sketch/models/FiltersCategoryModel.cpp PRE-CREATION 
>   krita/sketch/models/FiltersModel.h PRE-CREATION 
>   krita/sketch/models/FiltersModel.cpp PRE-CREATION 
>   krita/sketch/models/KeyboardModel.h PRE-CREATION 
>   krita/sketch/models/KeyboardModel.cpp PRE-CREATION 
>   krita/sketch/models/LayerCompositeDetails.h PRE-CREATION 
>   krita/sketch/models/LayerCompositeDetails.cpp PRE-CREATION 
>   krita/sketch/models/LayerModel.h PRE-CREATION 
>   krita/sketch/models/LayerModel.cpp PRE-CREATION 
>   krita/sketch/models/LayerThumbProvider.h PRE-CREATION 
>   krita/sketch/models/LayerThumbProvider.cpp PRE-CREATION 
>   krita/sketch/models/MultiFeedRSSModel.h PRE-CREATION 
>   krita/sketch/models/MultiFeedRSSModel.cpp PRE-CREATION 
>   krita/sketch/models/PaletteColorsModel.h PRE-CREATION 
>   krita/sketch/models/PaletteColorsModel.cpp PRE-CREATION 
>   krita/sketch/models/PaletteModel.h PRE-CREATION 
>   krita/sketch/models/PaletteModel.cpp PRE-CREATION 
>   krita/sketch/models/PresetImageProvider.h PRE-CREATION 
>   krita/sketch/models/PresetImageProvider.cpp PRE-CREATION 
>   krita/sketch/models/PresetModel.h PRE-CREATION 
>   krita/sketch/models/PresetModel.cpp PRE-CREATION 
>   krita/sketch/models/RecentImageImageProvider.h PRE-CREATION 
>   krita/sketch/models/RecentImageImageProvider.cpp PRE-CREATION 
>   krita/sketch/models/RecentImagesModel.h PRE-CREATION 
>   krita/sketch/models/RecentImagesModel.cpp PRE-CREATION 
>   krita/sketch/qml/HelpPage.qml PRE-CREATION 
>   krita/sketch/qml/KritaSketchBase.qml PRE-CREATION 
>   krita/sketch/qml/MainPage.qml PRE-CREATION 
>   krita/sketch/qml/OpenImagePage.qml PRE-CREATION 
>   krita/sketch/qml/SaveImagePage.qml PRE-CREATION 
>   krita/sketch/qml/SettingsPage.qml PRE-CREATION 
>   krita/sketch/qml/WelcomePage.qml PRE-CREATION 
>   krita/sketch/qml/components/BusyIndicator.qml PRE-CREATION 
>   krita/sketch/qml/components/Button.qml PRE-CREATION 
>   krita/sketch/qml/components/CategorySwitcher.qml PRE-CREATION 
>   krita/sketch/qml/components/CheckBox.qml PRE-CREATION 
>   krita/sketch/qml/components/ColorSwatch.qml PRE-CREATION 
>   krita/sketch/qml/components/Dialog.qml PRE-CREATION 
>   krita/sketch/qml/components/Divider.qml PRE-CREATION 
>   krita/sketch/qml/components/DropShadow.qml PRE-CREATION 
>   krita/sketch/qml/components/ExpandingListView.qml PRE-CREATION 
>   krita/sketch/qml/components/Header.qml PRE-CREATION 
>   krita/sketch/qml/components/Label.qml PRE-CREATION 
>   krita/sketch/qml/components/ListItem.qml PRE-CREATION 
>   krita/sketch/qml/components/MessageStack.qml PRE-CREATION 
>   krita/sketch/qml/components/NewImageList.qml PRE-CREATION 
>   krita/sketch/qml/components/NewsList.qml PRE-CREATION 
>   krita/sketch/qml/components/Page.qml PRE-CREATION 
>   krita/sketch/qml/components/PageStack.js PRE-CREATION 
>   krita/sketch/qml/components/PageStack.qml PRE-CREATION 
>   krita/sketch/qml/components/PanelTextField.qml PRE-CREATION 
>   krita/sketch/qml/components/RangeInput.qml PRE-CREATION 
>   krita/sketch/qml/components/RecentFilesList.qml PRE-CREATION 
>   krita/sketch/qml/components/ScrollDecorator.qml PRE-CREATION 
>   krita/sketch/qml/components/Slider.qml PRE-CREATION 
>   krita/sketch/qml/components/TextField.qml PRE-CREATION 
>   krita/sketch/qml/components/TextFieldMultiline.qml PRE-CREATION 
>   krita/sketch/qml/components/VirtualKeyboard.qml PRE-CREATION 
>   krita/sketch/qml/images/shadow-smooth.png PRE-CREATION 
>   krita/sketch/qml/images/svg/checker-small.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/combo-arrows-white.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-A4landscape-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-A4portrait-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-add-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-add.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-apply-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-apply.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-back.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-camera-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-cancel-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-close.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-color_wheel.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-colorpicker.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-crop-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-crop.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-delete-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-delete.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-down.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-edit.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-erase.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-fileclip-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filenew-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filenew.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-fileopen-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-fileopen.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filesave.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filesaveas.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-fileshare.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-fill-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-fill.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filter_delete-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filter_load-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-filter_save-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-forward.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-gradient-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-gradient.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-help.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-krita_sketch.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-layer_filter-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-layer_group-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-layer_paint-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-locked_off-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-locked_on-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-minimize.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-mirror_c-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-mirror_h-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-mirror_v-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-move-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-move.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-paint-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-paint.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-palette-add-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-palette-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-palette-delete-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-palette.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-redo.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-add.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-apply.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-area.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-color.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-deselect.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-hide.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-intersect.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-polygon.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-rectangle.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-replace.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-reselect.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-show.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-select-sub.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-settings.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-switch.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-transform-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-transform.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-undo.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-up.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-visible_off-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-visible_off.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-visible_on-black.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-visible_on.svg PRE-CREATION 
>   krita/sketch/qml/images/svg/icon-web.svg PRE-CREATION 
>   krita/sketch/qml/panels/ColorPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/EditLayerPage.qml PRE-CREATION 
>   krita/sketch/qml/panels/EditPresetPage.qml PRE-CREATION 
>   krita/sketch/qml/panels/FilterPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/LayersPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/MenuPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/NewImagePanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/OpenImagePanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/Panel.qml PRE-CREATION 
>   krita/sketch/qml/panels/PanelBar.qml PRE-CREATION 
>   krita/sketch/qml/panels/PanelDropArea.qml PRE-CREATION 
>   krita/sketch/qml/panels/PresetsPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/SelectPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/ToolPanel.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/blur.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/brightnesscontrast.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/burn.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/colortoalpha.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/colortransfer.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/dodge.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/emboss.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/gaussian PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/gaussiannoisereducer.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/hsvadjustment.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/lens PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/levels.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/motion PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/noise.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/nothing-to-configure.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/oilpaint.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/perchannel.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/phongbumpmap.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/pixelize.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/raindrops.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/randompick.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/roundcorners.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/smalltiles.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/sobel.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/unsharp.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/wave.qml PRE-CREATION 
>   krita/sketch/qml/panels/filterconfigpages/waveletnoisereducer.qml PRE-CREATION 
>   krita/sketch/qml/panels/toolconfigpages/crop.qml PRE-CREATION 
>   krita/sketch/qml/panels/toolconfigpages/fill.qml PRE-CREATION 
>   krita/sketch/qml/panels/toolconfigpages/gradient.qml PRE-CREATION 
>   krita/sketch/qml/panels/toolconfigpages/move.qml PRE-CREATION 
>   krita/sketch/qml/panels/toolconfigpages/paint.qml PRE-CREATION 
>   krita/sketch/qml/panels/toolconfigpages/transform.qml PRE-CREATION 
>   krita/sketch/qmldir PRE-CREATION 
>   krita/ui/CMakeLists.txt cc69242 
>   krita/ui/canvas/kis_abstract_canvas_widget_factory.h PRE-CREATION 
>   krita/ui/canvas/kis_canvas2.h 638736c 
>   krita/ui/canvas/kis_canvas2.cpp 8445832 
>   krita/ui/canvas/kis_canvas_widget_base.h 0fac92d 
>   krita/ui/canvas/kis_coordinates_converter.cpp 054bd3a 
>   krita/ui/canvas/kis_qpainter_canvas_widget_factory.h PRE-CREATION 
>   krita/ui/canvas/kis_qpainter_canvas_widget_factory.cpp PRE-CREATION 
>   krita/ui/flake/kis_node_shape.cpp 258d011 
>   krita/ui/input/kis_change_primary_setting_action.cpp 7fe7fdc 
>   krita/ui/input/kis_input_manager.h aa815d6 
>   krita/ui/input/kis_input_manager.cpp faaa779 
>   krita/ui/input/kis_pan_action.h f941416 
>   krita/ui/input/kis_pan_action.cpp 34a1aebc 
>   krita/ui/input/kis_shortcut_matcher.h f87dd68 
>   krita/ui/input/kis_shortcut_matcher.cpp 6423213 
>   krita/ui/input/kis_tool_invocation_action.cpp 6b5df9a 
>   krita/ui/input/kis_touch_shortcut.h PRE-CREATION 
>   krita/ui/input/kis_touch_shortcut.cpp PRE-CREATION 
>   krita/ui/input/kis_zoom_action.h b810c21 
>   krita/ui/input/kis_zoom_action.cpp 1133f2d 
>   krita/ui/kis_canvas_resource_provider.h 19778ea 
>   krita/ui/kis_clipboard.h 4ea41e1 
>   krita/ui/kis_clipboard.cc 9f3da2f 
>   krita/ui/kis_config.h 23ad5f6 
>   krita/ui/kis_config.cc a04e39f 
>   krita/ui/kis_doc2.h 73ccb0a 
>   krita/ui/kis_doc2.cc 17276ca 
>   krita/ui/kis_mask_manager.h 696a572 
>   krita/ui/kis_mask_manager.cc 2274d25 
>   krita/ui/kis_node_manager.h 1f81239 
>   krita/ui/kis_node_manager.cpp 0d33338 
>   krita/ui/kis_node_model.cpp 675f7fc 
>   krita/ui/kis_paintop_box.cc 9b90061 
>   krita/ui/kis_part2.cpp 83d5f34 
>   krita/ui/kis_selection_manager.h 6dd4ec7 
>   krita/ui/kis_selection_manager.cc 4d0f955 
>   krita/ui/kis_view2.h 32a707f 
>   krita/ui/kis_view2.cpp e472766 
>   krita/ui/opengl/kis_opengl_canvas2.h 4520e5f 
>   krita/ui/opengl/kis_opengl_canvas2.cpp e6b7ab9 
>   krita/ui/tests/kis_image_view_converter_test.cpp f91e021 
>   krita/ui/tests/kis_zoom_and_pan_test.cpp 794c1ae 
>   krita/ui/tool/kis_painting_information_builder.h d9ab251 
>   krita/ui/tool/kis_painting_information_builder.cpp 50f877e 
>   krita/ui/widgets/kis_workspace_chooser.cpp 2fd8f5b 
>   libs/flake/CMakeLists.txt 7d03157 
>   libs/flake/KoCanvasBase.h 1663e25 
>   libs/flake/KoCanvasControllerWidget.h f5d6091 
>   libs/flake/KoCanvasControllerWidget.cpp db7ded4 
>   libs/flake/KoPointerEvent.h 9c8ab1a 
>   libs/flake/KoPointerEvent.cpp 5c2982b 
>   libs/flake/KoToolBase.h f6397e2 
>   libs/flake/KoToolBase.cpp 0520ec3 
>   libs/flake/KoToolManager.cpp 7885635 
>   libs/flake/KoToolProxy.h 703923d 
>   libs/flake/KoToolProxy.cpp 80081c6 
>   libs/flake/tests/TestSnapStrategy.h 5bdaae7 
>   libs/flake/tests/TestSnapStrategy.cpp 37482a3 
>   libs/kopageapp/KoPACanvasItem.h b0bf8e3 
>   libs/main/KoDocument.h 3372060 
>   libs/main/KoDocument.cpp a871e1f 
>   libs/main/KoMainWindow.h 1b3503f 
>   libs/main/KoMainWindow.cpp e84518d 
>   libs/main/KoPrintingDialog.cpp 6929233 
>   libs/pigment/benchmarks/KoCompositeOpsBenchmark.cpp 85675d2 
>   libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.cpp 2fd8179 
>   libs/pigment/compositeops/KoVcMultiArchBuildSupport.h b365fa1 
>   libs/widgets/CMakeLists.txt f8626c2 
>   libs/widgets/KoResourceServer.h e19b65a 
>   plugins/textshape/TextTool.cpp 0afc19f 
>   sheets/part/CanvasItem.h 5966e2a 
>   sheets/ui/RightToLeftPaintingStrategy.cpp 223c6f7 
>   words/part/KWCanvasItem.h f2c5077 
> 
> Diff: http://git.reviewboard.kde.org/r/113327/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131019/ea57e9f6/attachment.htm>

More information about the calligra-devel mailing list