Review Request 109907: Use platform native file dialogs

[Yue Liu]

> On Oct. 2, 2013, 12:15 a.m., Andrius da Costa Ribas wrote:
> > In my work I use to save documents. In remote (sftp) places because I have not much disk in my local machine. This is not possible using native win dialog. IMHO this should be a configurable setting, as it is with KDE4 in general (not sure how this is working on KF5)

now I feel maybe I should just use plain static qfiledialog methods at first..

So what this patch did is, for open it internally called static qfiledialog methods, so it will use kfiledialog and when you don't specify native=true in kdeglobals it still use kfiledialog on Windows and Mac. For saving I used qfiledialog->exec() in window modal, somehow it does not use kfiledialog (not sure if it is a bug or intentionally designed in kfiledialog), replacing save dialogs code with static qfiledialog methods solves your concern, and the code would be even simpler, but we'll lost sheet style dialog in osx.


- Yue


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109907/#review41091
-----------------------------------------------------------


On Oct. 1, 2013, 10:38 p.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109907/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 10:38 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Currently kfiledialog and kofiledialog is widely used, this results in non-native file dialog on Mac/Windows/Gnome. However, qfiledialog static methods does not support modal sheet in Mac, so a KoModalFileDialog is created for window-modal file dialog, such as save as or import, while other file dialog such as open will use qfiledialog static methods.
> 
> This is a very first version which blocks save as encrypted since encrypted odf has same suffix as normal odf while when using native dialog you have to use suffix to distinguish different format. My idea is to create another menu item "Save As Encrypted..." where encrypted odf will be saved.
> 
> There are still many file dialogs not touched yet, and for places where kfilewidget is used, such as startup file open widget, kexi file widget, export to pdf widget, it is impossible to use native dialog. My idea is redesign those widget and split the configure part and file chooser part into two separate dialogs, then use native file dialogs.
> 
> 
> Diffs
> -----
> 
>   flow/part/flow.rc f6fa60a 
>   krita/plugins/extensions/bigbrother/bigbrother.cc 5ba4ac5 
>   libs/main/CMakeLists.txt 3a9110c 
>   libs/main/KoDetailsPaneBase.ui d692a00 
>   libs/main/KoExistingDocumentPane.h fd7b4fd 
>   libs/main/KoExistingDocumentPane.cpp 2ea6746 
>   libs/main/KoFileDialog.h da94281 
>   libs/main/KoFileDialog.cpp c5a7fc2 
>   libs/main/KoFileDialogHelper.h PRE-CREATION 
>   libs/main/KoFileDialogHelper.cpp PRE-CREATION 
>   libs/main/KoMainWindow.h 1b3503f 
>   libs/main/KoMainWindow.cpp 10cef0e 
>   libs/main/KoOpenPane.h 4e9ac13 
>   libs/main/KoOpenPane.cpp 53d4b48 
>   libs/main/KoOpenPaneBase.ui 0b2f2cf 
>   plan/workpackage/application.cpp b3642d6 
>   sheets/dialogs/CSVDialog.h 0763538 
>   sheets/dialogs/CSVDialog.cpp 4d6a19d 
>   sheets/sheets.rc 76439c0 
>   stage/part/stage.rc 2dba463 
>   stage/stage.rc d0b912f 
>   stage/stage_only.rc 73c743b 
>   words/part/author/author.rc b5567f5 
>   words/part/words.rc 31cabbd 
> 
> Diff: http://git.reviewboard.kde.org/r/109907/diff/
> 
> 
> Testing
> -------
> 
> Works fine on OS X 10.8
> 
> 
> File Attachments
> ----------------
> 
> save as dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/08/Screen_Shot_2013-04-07_at_11.54.47_PM.png
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131002/f9f7677c/attachment.htm>