Review Request 114193: Use LibFindMacros.cmake to simplify package finding, fixed FindFFTW3, FindLIBWPD, FINDLIBWPG on mac, and some other mac fixes.

Yue Liu yue.liu at mail.com
Fri Nov 29 22:43:47 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114193/
-----------------------------------------------------------

(Updated Nov. 29, 2013, 10:43 p.m.)


Review request for Calligra.


Changes
-------

Fixed for Linux. Tested on Arch Linux


Repository: calligra


Description (updated)
-------

Use LibFindMacros.cmake to simplify package finding, fixed FindFFTW3, FindLIBWPD, FINDLIBWPG on mac, and some other mac fixes.


Diffs (updated)
-----

  CMakeLists.txt 6587ecc 
  cmake/modules/FindFFTW3.cmake a4c8997 
  cmake/modules/FindLibWpg.cmake PRE-CREATION 
  cmake/modules/FindWPD.cmake 0f666b3 
  cmake/modules/FindWPG.cmake 066e579 
  cmake/modules/LibFindMacros.cmake PRE-CREATION 
  filters/flow/visio/import/CMakeLists.txt 55b8488 
  filters/karbon/wpg/CMakeLists.txt e8600a0 
  filters/words/wordperfect/import/CMakeLists.txt cbcf650 
  filters/words/works/import/CMakeLists.txt 082cb31 
  filters/writerperfect/CMakeLists.txt 1f57075 
  krita/image/CMakeLists.txt da1102c 
  krita/image/kis_assert.cpp 17a85f8 
  krita/plugins/extensions/gmic/CMakeLists.txt 15291af 
  libs/main/KoDocument.cpp 0a17961 
  libs/widgets/KoEditColorSetDialog.cpp d683bcc 

Diff: http://git.reviewboard.kde.org/r/114193/diff/


Testing
-------

Works on OSX 10.9, but I feel something wrong for windows. Please check if the FindXXX changes work on windows.


Thanks,

Yue Liu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131129/0f9a9aa0/attachment.htm>


More information about the calligra-devel mailing list