Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111914/#review44845
-----------------------------------------------------------

Ship it!


if you do the visible thing, and printing thing we discussed on irc you may squash-merge

- C. Boemann


On Nov. 29, 2013, 8:56 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111914/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 8:56 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch adds support for annotations, also known as comments, to Words and Author. 
> 
> Annotations work now and you can check out the branch text-annotation if you want to test it.
> 
> There is one misfeature: annotations are shown when printing but that should be disabled asap.
> 
> 
> Diffs
> -----
> 
>   ANNOTATIONS-ODF PRE-CREATION 
>   TODO-ANNOTATIONS PRE-CREATION 
>   libs/flake/CMakeLists.txt a6614f2 
>   libs/flake/KoAnnotationLayoutManager.h PRE-CREATION 
>   libs/flake/KoAnnotationLayoutManager.cpp PRE-CREATION 
>   libs/flake/KoShapeController.h 2ae03ca 
>   libs/flake/KoShapeController.cpp 817ba5e 
>   libs/flake/KoShapeManager.h 9df1671 
>   libs/flake/KoShapeManager.cpp 36666ce 
>   libs/kotext/CMakeLists.txt 2e66080 
>   libs/kotext/KoAnnotation.h c4457fd 
>   libs/kotext/KoAnnotation.cpp e5a8a53 
>   libs/kotext/KoTextEditor.h 9fd3c05 
>   libs/kotext/KoTextEditor.cpp 40ac427 
>   libs/kotext/KoTextRangeManager.cpp fdde8ee 
>   libs/kotext/commands/AddAnnotationCommand.h PRE-CREATION 
>   libs/kotext/commands/AddAnnotationCommand.cpp PRE-CREATION 
>   libs/kotext/commands/DeleteAnnotationsCommand.h PRE-CREATION 
>   libs/kotext/commands/DeleteAnnotationsCommand.cpp PRE-CREATION 
>   libs/kotext/commands/DeleteCommand.cpp ad81ce0 
>   libs/kotext/opendocument/KoTextLoader.cpp 7831109 
>   libs/main/KoModeBox.cpp 0f5f2f4 
>   libs/textlayout/KoTextDocumentLayout.h a0fabcf 
>   libs/textlayout/KoTextDocumentLayout.cpp a314223 
>   plugins/textshape/AnnotationTextShape.h PRE-CREATION 
>   plugins/textshape/AnnotationTextShape.cpp PRE-CREATION 
>   plugins/textshape/AnnotationTextShapeFactory.h PRE-CREATION 
>   plugins/textshape/AnnotationTextShapeFactory.cpp PRE-CREATION 
>   plugins/textshape/CMakeLists.txt 1838cf1 
>   plugins/textshape/ReviewTool.h e2b8f95 
>   plugins/textshape/ReviewTool.cpp 53c87c7 
>   plugins/textshape/ReviewToolFactory.cpp 48b56f1 
>   plugins/textshape/SimpleRootAreaProvider.cpp eb76e57 
>   plugins/textshape/TextPlugin.cpp b99243f 
>   plugins/textshape/TextTool.h a87a9d1 
>   plugins/textshape/TextTool.cpp 96294a0 
>   plugins/textshape/TextToolFactory.cpp 0ced315 
>   plugins/textshape/dialogs/SimpleAnnotationWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleAnnotationWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleAnnotationWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui 07b3cda 
>   words/part/KWCanvas.cpp f33d993 
>   words/part/KWCanvasBase.h 31111ce 
>   words/part/KWCanvasBase.cpp 22d1c5f 
>   words/part/KWDocument.h fc552ba 
>   words/part/KWDocument.cpp c1f70ca 
>   words/part/KWOdfSharedLoadingData.cpp 450b580 
>   words/part/KWOdfWriter.cpp 771eee2 
>   words/part/KWView.h 473348f 
>   words/part/KWView.cpp 7c61533 
>   words/part/KWViewModeNormal.cpp 88e67b2 
>   words/part/frames/KWTextFrameSet.cpp 1bb513c 
>   words/part/words.rc 7a26cb8 
> 
> Diff: http://git.reviewboard.kde.org/r/111914/diff/
> 
> 
> Testing
> -------
> 
> Created test files in LO with annotations and loaded them.  Also created our own test files.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131129/460149e9/attachment.htm>