Review Request 114193: Use LibFindMacros.cmake to simplify package finding, fixed FindFFTW3, FindLIBWPD, FINDLIBWPG on mac, and some other mac fixes.
Boudewijn Rempt
boud at valdyas.org
Fri Nov 29 10:22:20 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114193/#review44778
-----------------------------------------------------------
It's a bit hard for me to check on Windows, because on Windows, I provide none of these dependencies anyway. I should provide fftw3, but haven't gotten round to doing that yet.
- Boudewijn Rempt
On Nov. 29, 2013, 2:13 a.m., Yue Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114193/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2013, 2:13 a.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> CMakeLists.txt 6587ecc
> cmake/modules/FindFFTW3.cmake a4c8997
> cmake/modules/FindLIBWPD.cmake PRE-CREATION
> cmake/modules/FindLibWpg.cmake PRE-CREATION
> cmake/modules/FindWPD.cmake 0f666b3
> cmake/modules/FindWPG.cmake 066e579
> cmake/modules/LibFindMacros.cmake PRE-CREATION
> filters/flow/visio/import/CMakeLists.txt 55b8488
> filters/karbon/wpg/CMakeLists.txt e8600a0
> filters/words/wordperfect/import/CMakeLists.txt cbcf650
> filters/words/works/import/CMakeLists.txt 082cb31
> filters/writerperfect/CMakeLists.txt 1f57075
> krita/image/CMakeLists.txt da1102c
> krita/image/kis_assert.cpp 17a85f8
> krita/plugins/extensions/gmic/CMakeLists.txt 15291af
> libs/main/KoDocument.cpp 0a17961
> libs/widgets/KoEditColorSetDialog.cpp d683bcc
>
> Diff: http://git.reviewboard.kde.org/r/114193/diff/
>
>
> Testing
> -------
>
> Works on OSX 10.9, but I feel something wrong for windows. Please check if the FindXXX changes work on windows.
>
>
> Thanks,
>
> Yue Liu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131129/9c6acb5a/attachment.htm>
More information about the calligra-devel
mailing list