Review Request 114102: Modify selection dialogs rework

Juan Palacios jpalaciosdev at gmail.com
Mon Nov 25 12:19:59 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114102/
-----------------------------------------------------------

Review request for Calligra, Sven Langkamp and Boudewijn Rempt.


Repository: calligra


Description
-------

This patch adds the units supported by KoUnit to border, feather, grow and shrink selection dialogs. It also modifies the layout of all of them.


Diffs
-----

  krita/plugins/extensions/modify_selection/dlg_border_selection.h cf73269 
  krita/plugins/extensions/modify_selection/dlg_border_selection.cc 53c72ac 
  krita/plugins/extensions/modify_selection/dlg_feather_selection.h d7d28b6 
  krita/plugins/extensions/modify_selection/dlg_feather_selection.cc bf1541d 
  krita/plugins/extensions/modify_selection/dlg_grow_selection.h c1ead18 
  krita/plugins/extensions/modify_selection/dlg_grow_selection.cc 0448256 
  krita/plugins/extensions/modify_selection/dlg_shrink_selection.h e47f57a 
  krita/plugins/extensions/modify_selection/dlg_shrink_selection.cc 6e18377 
  krita/plugins/extensions/modify_selection/wdg_border_selection.ui b144061 
  krita/plugins/extensions/modify_selection/wdg_feather_selection.ui b670ca7 
  krita/plugins/extensions/modify_selection/wdg_grow_selection.ui 624e793 
  krita/plugins/extensions/modify_selection/wdg_shrink_selection.ui ed8587f 
  krita/ui/operations/kis_operation_ui_widget_factory.h 62a90bc 

Diff: http://git.reviewboard.kde.org/r/114102/diff/


Testing
-------


File Attachments
----------------

dlg_border.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/7fb9400e-ff7d-451e-8c06-28e2158b2148__dlg_border.png
dlg_feather.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/65acb509-8a48-4d60-913d-e6250f508537__dlg_feather.png
dlg_grow.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/1bef42fc-ef9d-4511-877a-61c08982723f__dlg_grow.png
dlg_shrink.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/4b89b874-c99b-4ccc-b002-9e858d01aee2__dlg_shrink.png


Thanks,

Juan Palacios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131125/12df1df1/attachment.htm>


More information about the calligra-devel mailing list