Review Request 113783: fix tests on provided area rect in TestDocumentLayout.cpp

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113783/#review43320
-----------------------------------------------------------

Ship it!


thanks, yes your fixes makes sense



- C. Boemann


On Nov. 10, 2013, 5:31 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113783/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 5:31 a.m.)
> 
> 
> Review request for Calligra, C. Boemann and Inge Wallin.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> 83902350e8b0e2f13443ea19ba95b6397261620b includes the squashed a32fd9886c719a9d019c7d13925a862801ad675d, which has the message:
> "Seems that boemann is not building the tests.  Booo!"
> 
> I could only add:
> "Seems that boemann & ingwa are not running the tests. More Booo!" ;)
> 
> The other comment there though I have to paraphrase here:
> "The test now succeeds but I don't know exactly if the tested rects make sense."
> 
> Do they?
> 
> Added "+ 100" to all the tests for TestBlockLayout, to adapt to the x and y offset resulting from this change to libs/textlayout/tests/MockRootAreaProvider.cpp:
> 
> -    m_suggestedSize(QSizeF(200,1000)),
> +      m_suggestedRect(QRectF(100, 100, 200,1000)),
> 
> 
> Let's make sure again there is no red in http://build.kde.org/job/calligra_master/test/?width=800&height=600
> Yes, krita devs need to do definitely something about it, but it is not only them. So everybody don't forget to give it a look now and then.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/tests/TestBlockLayout.cpp 422e97e 
>   libs/textlayout/tests/TestDocumentLayout.cpp c411305 
> 
> Diff: http://git.reviewboard.kde.org/r/113783/diff/
> 
> 
> Testing
> -------
> 
> Oh yes ;)
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131110/b97e6d33/attachment.htm>