Review Request 110708: Add some basic unit tests for the style manager

C. Boemann cbr at boemann.dk
Thu May 30 07:33:21 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110708/#review33395
-----------------------------------------------------------

Ship it!


Thanks, very nice that you have taken the initiative on this

- C. Boemann


On May 29, 2013, 11:04 a.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110708/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 11:04 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Add some basic unit tests for the style manager.
> 
> The test simply tests that adding/removing styles work and that the correct signals are emitted. I'll see if I can write some more interesting tests later on.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.h 77050c1 
>   libs/kotext/styles/KoSectionStyle.h b5ec2e1 
>   libs/kotext/styles/KoTableCellStyle.h 54f6c27 
>   libs/kotext/styles/KoTableColumnStyle.h 41f250a2 
>   libs/kotext/styles/KoTableRowStyle.h aa0638c 
>   libs/kotext/styles/KoTableStyle.h 339dd2e 
>   libs/kotext/styles/tests/CMakeLists.txt a054a39 
>   libs/kotext/styles/tests/TestStyleManager.h PRE-CREATION 
>   libs/kotext/styles/tests/TestStyleManager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110708/diff/
> 
> 
> Testing
> -------
> 
> The tests all pass here.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130530/6c1bb036/attachment.htm>


More information about the calligra-devel mailing list