Review Request 108677: Add support for hyperlinks in kexi buttons

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108677/#review33383
-----------------------------------------------------------



kexi/kexiutils/KexiHyperLinkHandler.h
<http://git.reviewboard.kde.org/r/108677/#comment24689>

    Since KexiHyperLinkHandler won't be instantiated and it just contains static function and enum, I propose to just move static openHyperLink() to kexiutils/utils.cpp/h so it'll be used as KexiUtils::openHyperLink().



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24690>

    Would be good to have this instead:
    
    class OpenHyperlinkOptions {
    public:
     HyperlinkTool tool;
     bool allowExecutable;
     bool allowRemote;
    };
    
    (bool args like it's now are against the API design)



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24691>

    "does not exists" -> "does not exist"
    
    and let's phrase it more like in widget/KexiFileWidget.cpp:
    
    "The file or directory <filename>%1</filename> does not exist."



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24692>

    let's phrase it like:
    
    "Invalid hyperlink <link>%1</link>."



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24693>

    let's phrase it like:
    
    "Executable <link>%1</link> not allowed."



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24694>

    let's phrase it like:
    
    "Remote hyperlink <link>%1</link> not allowed."



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24695>

    let's phrase it like:
    
    "Do you want to run this file?"
    "<warning>Running executables can be dangerous.</warning>"



kexi/kexiutils/KexiHyperLinkHandler.cpp
<http://git.reviewboard.kde.org/r/108677/#comment24696>

    "KexiRunExecutable" -> "AllowRunExecutable"


- Jarosław Staniek


On May 29, 2013, 8 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108677/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 8 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> added support for hyperlinks in kexidbpushbutton and kexicommandlinkbutton
> 
> 
> Diffs
> -----
> 
>   kexi/kexiutils/CMakeLists.txt 943eae1f147c65fccba94098f7f93beaf26cc9d5 
>   kexi/kexiutils/KexiCommandLinkButton.h e5270eaeacd4e563742ca1120caaaad561f45d69 
>   kexi/kexiutils/KexiCommandLinkButton.cpp a1cff931012678b7c6dac09f4c70411c773db84e 
>   kexi/kexiutils/KexiHyperLinkHandler.h PRE-CREATION 
>   kexi/kexiutils/KexiHyperLinkHandler.cpp PRE-CREATION 
>   kexi/plugins/forms/CMakeLists.txt 35142914417d12fba7d03078657690582d584612 
>   kexi/plugins/forms/kexidbfactory.cpp ff6146b7f2de008ad1bcce7b97f8007fed37710c 
>   kexi/plugins/forms/kexiformview.cpp dd6d31298955b65941c501f15f0b0f5749d7c4ae 
>   kexi/plugins/forms/widgets/kexidbautofield.cpp daa3c2ee730bd232a7ff656d6a3d00c2d87007cf 
>   kexi/plugins/forms/widgets/kexidbcommandlinkbutton.h 39a68c8c43c912985992c389b88bd0c49aa7f703 
>   kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp 1592d2e0ba04a24cd856519fe4d988dd25eef5b9 
>   kexi/plugins/forms/widgets/kexipushbutton.h c3b9113f0839a704c0807e70afff9a5bdf232d50 
>   kexi/plugins/forms/widgets/kexipushbutton.cpp 0cfe327c83f6abc4597826456bed6f6bbabe7dbd 
>   kexi/widget/CMakeLists.txt cf6be390218b4e620719acd4bc5e0c6fb19d1531 
> 
> Diff: http://git.reviewboard.kde.org/r/108677/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130529/25509920/attachment.htm>