Review Request 110624: Epub generation improvement (new metadata)

[Jérémy BOURDIOL]

> On May 23, 2013, 9:21 p.m., Inge Wallin wrote:
> > filters/words/epub/EpubFile.cpp, line 259
> > <http://git.reviewboard.kde.org/r/110624/diff/1/?file=146084#file146084line259>
> >
> >     Yes, there should probably be a test to see if there actually is a cover before any attempt to save it is done. Unless the <guide> element can be empty, of course. I don't know the spec by heart here.

I think the guide element could be empty (but perhaps not suitable).
Anyway, after further researches i found that guide element is deprecated in the EPub3 spec, it's allowed but just for compatibility with EPub2.X.
So, I think i will just remove the guide part so everybody will have access to author and subjects metadata.


- Jérémy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110624/#review33065
-----------------------------------------------------------


On May 23, 2013, 8:11 p.m., Jérémy BOURDIOL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110624/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 8:11 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> A little improvement of Epub export with new metadata like author and subjects.
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/EpubFile.cpp 8e69d65 
> 
> Diff: http://git.reviewboard.kde.org/r/110624/diff/
> 
> 
> Testing
> -------
> 
> The generated Epud is tested on Callibre to know if metadata are readable
> It's also checked with http://validator.idpf.org/
> 
> Here is an error occuring when there is no cover image, not of my fate, that's it in master (as i'm writting):
> (ERROR	OEBPS/toc.ncx	14	11	element "navMap" incomplete; missing required element "navPoint")
> 
> 
> Thanks,
> 
> Jérémy BOURDIOL
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130529/6233536e/attachment.htm>