Review Request 110696: Fix incrementing of style ID counter in StyleManager

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110696/#review33297
-----------------------------------------------------------

Ship it!


Ship It!

- C. Boemann


On May 28, 2013, 2:42 p.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110696/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 2:42 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> In KoStyleManager::add(KoCharacterStyle *style) and KoStyleManager::add(KoParagraphStyle *style), the d->s_stylesNumber static variable used for assigning style IDs was wrongly used after it had been incremented. I fixed this and also moved the incrementing to a separate statement at the end of the block in the other functions, to minimize the risk of it happening again.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoStyleManager.cpp 32cbbcb 
> 
> Diff: http://git.reviewboard.kde.org/r/110696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130528/19dceb5e/attachment.htm>