Review Request 110579: Fix compilation on ARM: result of dividing by 2.0 is double, so not qreal (qMax needs same types)

Commit Hook null at kde.org
Tue May 21 18:10:25 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110579/
-----------------------------------------------------------

(Updated May 21, 2013, 5:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Description
-------

Found when compiling 2.7 Beta2 on build.merproject.org with ARM targets.

So will also backport to 2.7

Instead dividing qreal by 2 (integer) also results in qreal. But preferred to be more explicit here, as some might think that result is integer (I had to look up at least ;) )


Diffs
-----

  plugins/formulashape/elements/MultiscriptElement.cpp 9cdcc56 

Diff: http://git.reviewboard.kde.org/r/110579/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130521/8afa41a1/attachment.htm>


More information about the calligra-devel mailing list