Review Request 110579: Fix compilation on ARM: result of dividing by 2.0 is double, so not qreal (qMax needs same types)

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110579/#review32908
-----------------------------------------------------------

Ship it!


You don't have to have a review for qreal-ing floating point constants.

- Inge Wallin


On May 21, 2013, 4:40 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110579/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 4:40 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Found when compiling 2.7 Beta2 on build.merproject.org with ARM targets.
> 
> So will also backport to 2.7
> 
> Instead dividing qreal by 2 (integer) also results in qreal. But preferred to be more explicit here, as some might think that result is integer (I had to look up at least ;) )
> 
> 
> Diffs
> -----
> 
>   plugins/formulashape/elements/MultiscriptElement.cpp 9cdcc56 
> 
> Diff: http://git.reviewboard.kde.org/r/110579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130521/c3c40f8b/attachment.htm>