Review Request 110244: Perspective grid feature moved to Perspective Assistant

[Shivaraman Aiyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110244/
-----------------------------------------------------------

(Updated May 14, 2013, 5:46 p.m.)


Review request for Calligra.


Changes
-------

Fixed the CMakeList.txt file, everything is working now.


Description
-------

Perspective Grid has a feature of creating a new grid from its side handles, snapping two of the handles to the parent grid. As Perspective Assistant is more flexible, it was a better option to put the side handle feature to it. This diff enables the Perspective Assistant to create new Perspective Assistant from the current Assistants.


Diffs (updated)
-----

  krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.h 16cd814 
  krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.cc 13e8f32 
  krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h e3bee14 
  krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc 34b8a71 
  krita/plugins/assistants/RulerAssistant/ruler_assistant_tool.cc fc9ab85 
  krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc 4f6dee4 
  krita/ui/CMakeLists.txt 37e4635 
  krita/ui/canvas/kis_canvas_decoration.h c9ed223 
  krita/ui/canvas/kis_canvas_decoration.cc 5157679 
  krita/ui/canvas/kis_canvas_widget_base.cpp 166a529 
  krita/ui/canvas/kis_grid_manager.h ada17a6 
  krita/ui/canvas/kis_grid_manager.cpp efd6c7b 
  krita/ui/canvas/kis_perspective_grid_manager.h 5a4753e 
  krita/ui/canvas/kis_perspective_grid_manager.cpp 2d6d339 
  krita/ui/kis_painting_assistant.h 2fb513c 
  krita/ui/kis_painting_assistant.cc 9fd2ec3 
  krita/ui/kis_painting_assistants_manager.h 7ca4119 
  krita/ui/kis_painting_assistants_manager.cc 6f9ddbb 
  krita/ui/kis_selection_decoration.h cf86ada 
  krita/ui/kis_selection_decoration.cc d442729 
  krita/ui/kra/kis_kra_saver.cpp c84b0c7 

Diff: http://git.reviewboard.kde.org/r/110244/diff/


Testing
-------

Basic preliminary testing done include:
1) Test if rest of the Assistants are working - done, passed
2) Test the working of the side handles - done, passed
3) Test if all the assistants working together - done, passed
4) Test if the special cases are also working  - done, passed


Thanks,

Shivaraman Aiyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130514/0b31170d/attachment.htm>