Review Request 110408: Improve the styles handling in libs/odf/styles

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110408/#review32396
-----------------------------------------------------------


As said before I think all this code should move to the docx filter as the way it is not I can't see how it will fit with the current style loading code at all. Please move to the filter and once there is a patch that will integrate it with the rest of the applications we should move it to libs. This way we will make sure we don't clutter the libs as long it is not needed there.

- Thorsten Zachmann


On May 12, 2013, 4:22 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110408/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 4:22 p.m.)
> 
> 
> Review request for Calligra and Matus Uzak.
> 
> 
> Description
> -------
> 
> This is the second step in the quest to improve styles handling in Calligra.  This patch introduces text-properties, paragraph-properties and graphic-properties in the styles, which means that more specific information than only attributes. The style:text-properties element don't have any child elements but paragraph-properties do (background-image, drop-cap and tab-stops) and also graphic-properties.
> 
> Not everything is implemented yet but I wanted to support style:background-image in libs/odf for the styles that are already in use everywhere before implementing it here.
> 
> In the short term, this is important for the docx filter, and to save back named styles in Karbon and styles with family=graphic in all applications.
> 
> 
> Diffs
> -----
> 
>   libs/odf/CMakeLists.txt b3940c1 
>   libs/odf/styles/KoOdfGraphicProperties.h PRE-CREATION 
>   libs/odf/styles/KoOdfGraphicProperties.cpp PRE-CREATION 
>   libs/odf/styles/KoOdfParagraphProperties.h PRE-CREATION 
>   libs/odf/styles/KoOdfParagraphProperties.cpp PRE-CREATION 
>   libs/odf/styles/KoOdfStyle.cpp aac9ea2 
>   libs/odf/styles/KoOdfStyleProperties.h 9453989 
>   libs/odf/styles/KoOdfStyleProperties.cpp 7a34bf9 
>   libs/odf/styles/KoOdfTextProperties.h PRE-CREATION 
>   libs/odf/styles/KoOdfTextProperties.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110408/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130512/0d063245/attachment.htm>