Review Request 109214: Kexi asks for passwords without modal dialogs; improved messages and assistants

[Boudewijn Rempt]

On Monday 06 May 2013 May 00:12:36 Friedrich W. H. Kossebau wrote:
> > 
> > Or what to do to get general (i.e. checking style, obvious mistakes, too
> > complex areas) reviews from non-Kexi people from Calligra? I sometimes
> > review non-Kexi code, without particular pattern, can I count for the same?
> 
> Well, at least I, given that you explicitely listed 5 people as reviewers, 
> assumed any of them will be more qualified to give this a review, so ignored 
> that one. Like I would ignore Krita or other related requests where lots of 
> people are listed explicitely.
> 
> Possibly some flag to ask explicitely non-core-kexi developers is needed then?

As for me, if a review request isn't about the core or krita, I will not try to do a review, especially if it's about kexi or plan where I simply don't have the knowledge to check a diff. Usually, I skip sheets, words and stage as well, since I don't feel very competent there either...

Furthermore, as far as I am concerned, the rules for review requests aren't like this. See http://community.kde.org/Calligra/Policies/Review_board_rules -- but basically

* if there is no review in a week, ping people
* if there is no review in another week, it can be committed

So you could have pushed a month and a half earlier.

And then, review requests are only necessary:
     * for the libraries (files under libs/), namely main, flake, kotext, odf.
     * when changeing important API's.
     * You want to commit in code that are used by many applications, like some plugins

So, this review request wasn't necessary in the first place. However, maintainers of applications can have different rules (like for Krita, the rule is that a review request is only necessary if you are doing a big refactoring, are new, or unsure about a change). You're the maintainer, so you can decide what is needed.


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl