Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

Thu Mar 28 08:45:10 GMT 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109746/#review29979
-----------------------------------------------------------


please remove all swp files from your commit


CMakeCache.txt
<http://git.reviewboard.kde.org/r/109746/#comment22348>

    this file should not be part of your commit
    
    looks like you are building inside your source tree, that is a big no no!


plugins/textshape/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109746/#comment22349>

    should be renamed to SelectBookmarkDialog
    
    (without KW)


plugins/textshape/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109746/#comment22350>

    why did you remove those blank lines, please change back


plugins/textshape/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109746/#comment22352>

    no trailing spaces please


plugins/textshape/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109746/#comment22353>

    no spaces please (there is an option in most editors to prevent that)


plugins/textshape/ReferencesTool.h
<http://git.reviewboard.kde.org/r/109746/#comment22354>

    please leave a blank line


plugins/textshape/ReferencesTool.h
<http://git.reviewboard.kde.org/r/109746/#comment22355>

    no trailing space please - and please fix the rest of the file as well - not going to point out every occurence (look for the red blocks on reviewboard)


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22356>

    please add space after ,


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22360>

    no space after *


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22357>

    please drop toAscii


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22358>

    space after if but not after (


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22359>

    some indentations seems missing here


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22361>

    uhm what is this for?


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22362>

    { belongs on this line, not the line above


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22364>

    space after if


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22363>

    no space after ( or before )


plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/109746/#comment22365>

    I wonder if in this case it wouldn't be better to just pop up the manage bookmarks dialog


- C. Boemann


On March 26, 2013, 7:04 p.m., Aman Madaan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109746/
> -----------------------------------------------------------
> 
> (Updated March 26, 2013, 7:04 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch adds the following features : 
> 
> 1. Inserting hyperlinks
>    -- User has a choice of inserting a link by specifying the target and the link text. Additionally, the 
>       user may supply values for target and rel attributes using a drop down list.  
>    -- The user may fetch the title from the web page itself (contents of the "title" tag ). This feature also
>       handles URL redirects. For example, ieee.com is finally redirected to http://www.ieee.org/index.html.
>       This feature will especially help in cases when a user has a list of links referred to and a list of 
>       references has to be created. Just copy/pasting the URL, clicking fetch and then insert will do the job.
> 
> 2. Linking to bookmarks
>    -- A user can specify a bookmark name and the link text. To help the user with inserting bookmark, 
>       an auto completer is used. This becomes helpful when the bookmarks have been given a name that 
>       are related to the context. (lastpagefirstpara or conclusions).
> 
> 3. Adding Bookmark using a labeled widget ( similar to the way footnote and endnote labels are entered )
> 
> 
> Diffs
> -----
> 
>   CMakeCache.txt PRE-CREATION 
>   CMakeFiles/cmake.check_cache PRE-CREATION 
>   plugins/textshape/CMakeLists.txt 084628c 
>   plugins/textshape/ReferencesTool.h 21caea8 
>   plugins/textshape/ReferencesTool.cpp 46bf06f 
>   plugins/textshape/dialogs/.LinkInsertionDialog.cpp.kate-swp PRE-CREATION 
>   plugins/textshape/dialogs/BookmarkLinkInsertionWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/BookmarkLinkInsertionWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/BookmarkLinkInsertionWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/KWSelectBookmark.ui PRE-CREATION 
>   plugins/textshape/dialogs/KWSelectBookmarkDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/KWSelectBookmarkDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/LinkInsertionDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/LinkInsertionDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/LinkInsertionDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleBookmarkWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleBookmarkWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleBookmarkWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp 2d1c1de 
>   plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui 55699bb 
>   plugins/textshape/dialogs/SimpleLinksWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleLinksWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleLinksWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleTableOfContentsWidget.h adfd010 
>   plugins/textshape/dialogs/WeblinkInsertionWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/WeblinkInsertionWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/WeblinkInsertionWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/s.txt PRE-CREATION 
>   words/part/.KWView.cpp.kate-swp PRE-CREATION 
>   words/part/KWView.cpp 8639acd 
> 
> Diff: http://git.reviewboard.kde.org/r/109746/diff/
> 
> 
> Testing
> -------
> 
> I have tested the following components : 
> 	
> 1	  Inserting Hyperlinks			
> 1.1	Simplest case  (works)		
> 1.2	Fetch title from URL (works)		
> 1.3	Fetch title from URL which has re directions (works)		
> 1.4	specify a URL without a scheme (works, appending an http:// to all the schemeless urls)
> 1.5	fetching from an non existing URL (Time out occurs and notifies user about the same)
> 				
> 2	Adding Bookmarks			
> 2.1	Simplest case (works)		
> 2.2	Adding a duplicate bookmark i.e. using a name that has been used before(User is notified and bookmark addition is aborted)	
> 				
> 3	Adding link to a bookmark			
> 3.1	Simplest case (works)		
> 3.2	Adding a link to a non existing bookmark (works,User is notified about non existence of the bookmark)
> 				
> 4	Manage bookmarks
> 4.1	user clicks on manage bookmarks	(works, Copy pasted the existing implementation. Looks like delete bookmark is broken.)	
> 
> 
> Thanks,
> 
> Aman Madaan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130328/07d01242/attachment.htm>