Review Request 109410: set the style to plastique if not running in KDE

Boudewijn Rempt boud at valdyas.org
Mon Mar 25 10:25:35 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109410/
-----------------------------------------------------------

(Updated March 25, 2013, 10:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Description
-------

For Krita, with its default dark theme, only two styles work: oxygen and plastique. Oxygen is default in KDE, if the user selects something else, it's their problem. On windows, osx and ubuntu, the default style is broken for krita, so hard-code plastique if the user is running krita outside KDE.

This means that on Windows, other apps than Krita will use the default windows style again. It might be worth it to reinstate the code that detects the windows version and sets the right style, but that is up for discussion.


Diffs
-----

  libs/main/KoApplication.cpp 87536f1 

Diff: http://git.reviewboard.kde.org/r/109410/diff/


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130325/66760cd7/attachment.htm>


More information about the calligra-devel mailing list