Review Request 109615: turn all filters in filters/ into individual products, make core calligralibs also a product

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109615/
-----------------------------------------------------------

(Updated March 23, 2013, 9:39 p.m.)


Review request for Calligra.


Changes
-------

Updated to new ascii export filter and odf-traverse lib.


Description
-------

Each filter in filters/ got turned into a product with the naming pattern "FILTER_A_TO_B", to hint in the name from which file/app to which file/app the filter works (I was surprised how many file->file filters there are).

Patch also turns the core calligra libs into a product "CALLIGRA_LIBS", as there are other products that do not rely on them, so possibly someone might want to skip these. At least it is also interesting to see what relies on them and what not.

Most checks are also fetched into the toplevel CMakeLists.txt, for consistency and overview. Also Poppler, WPG & Co. were checked more than once.

Really quite a long list of products. But it should help us to keep an overview what is provided by Calligra, instead of having stuff buried somewhere in deep folders.

BTW:
I wonder if meta products like "Words" should not also be able to result in all useful stuff to be built, like the suiting filters. That would need the addition of another tag next to "NEEDS", e.g. "LIKES", "WANTS" or "WISHES".


Diffs (updated)
-----

  CMakeLists.txt c4e14e7 
  cmake/productsets/active.cmake c366a6a 
  cmake/productsets/all.cmake 5f27fd4 
  cmake/productsets/creative.cmake 94d1768 
  cmake/productsets/desktop.cmake a732e36 
  devtools/cstester/visualimagecompare/CMakeLists.txt 6c46c62 
  filters/CMakeLists.txt 82bb2f1 
  filters/flow/CMakeLists.txt ed12fd2 
  filters/flow/visio/CMakeLists.txt c279d75 
  filters/flow/visio/import/CMakeLists.txt a20db2a 
  filters/karbon/CMakeLists.txt ee99220 
  filters/karbon/karbon1.x/CMakeLists.txt 517480a 
  filters/karbon/svg/CMakeLists.txt 09ada07 
  filters/karbon/wmf/CMakeLists.txt e7fff92 
  filters/karbon/wpg/CMakeLists.txt 351fd37 
  filters/karbon/xfig/CMakeLists.txt 2e62248 
  filters/plan/mpxj/CMakeLists.txt 52c331d 
  filters/sheets/CMakeLists.txt dc9bb06 
  filters/sheets/csv/CMakeLists.txt f6a5183 
  filters/sheets/excel/CMakeLists.txt 3f0f5d9 
  filters/sheets/excel/import/CMakeLists.txt 97661d3 
  filters/sheets/excel/sidewinder/CMakeLists.txt a35211d 
  filters/sheets/gnumeric/CMakeLists.txt ea65d20 
  filters/sheets/html/CMakeLists.txt aa54222 
  filters/sheets/latex/CMakeLists.txt 36cf84c 
  filters/sheets/opencalc/CMakeLists.txt 125d0db 
  filters/sheets/xlsx/CMakeLists.txt 5feddf2 
  filters/stage/CMakeLists.txt 91b07d8 
  filters/stage/kpr2odf/CMakeLists.txt 8cd64b9 
  filters/stage/powerpoint/CMakeLists.txt bc91c63 
  filters/stage/pptx/CMakeLists.txt a2d8f39 
  filters/words/CMakeLists.txt 51aebb8 
  filters/words/ascii/CMakeLists.txt f4dbf37 
  filters/words/docx/CMakeLists.txt 8a341a0 
  filters/words/epub/CMakeLists.txt 53513a1 
  filters/words/msword-odf/CMakeLists.txt b1d6adc 
  filters/words/rtf/CMakeLists.txt 954fbfd 
  filters/words/rtf/import/CMakeLists.txt aa0a94d 
  filters/words/wordperfect/CMakeLists.txt ad6de17 
  filters/words/wordperfect/import/CMakeLists.txt 6b15094 
  filters/words/works/CMakeLists.txt c279d75 
  filters/words/works/import/CMakeLists.txt 7a11da8 
  krita/plugins/formats/CMakeLists.txt 4b9090d 
  krita/plugins/formats/ora/CMakeLists.txt a285498 
  libs/CMakeLists.txt 8e23b21 

Diff: http://git.reviewboard.kde.org/r/109615/diff/


Testing
-------

Still builds fine for all default productsets for me.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130323/fd6143e6/attachment.htm>