Review Request 109666: fix Braindump's menubar ("View" behind "Help")
Friedrich W. H. Kossebau
kossebau at kde.org
Fri Mar 22 23:32:47 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109666/
-----------------------------------------------------------
Review request for Calligra and Cyrille Berger Skott.
Description
-------
Seems there is a bug in the XMLGUI system. Reported as https://bugs.kde.org/show_bug.cgi?id=317211
Also:
* Better set the xmlui file as early as possible in the view class (ust a gut feeling, as it seemed to work the old way as well)
* For default menus there is no need to add the title text, so removed it.
* For the translator also add a nice context info with the string "Shapes"
Diffs
-----
braindump/data/braindumpui.rc 005fb98
braindump/data/braindumpview.rc 999c949
braindump/src/View.cpp ec1a0bd
Diff: http://git.reviewboard.kde.org/r/109666/diff/
Testing
-------
Works for me :)
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130322/b4e77993/attachment.htm>
More information about the calligra-devel
mailing list