Review Request 109214: Kexi asks for passwords without modal dialogs; improved messages and assistants

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109214/
-----------------------------------------------------------

(Updated March 19, 2013, 10:59 p.m.)


Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.


Description
-------

Main Window
*[code] Message handler now can set redirection to other handler (needed to cleanly implement error callouts for the Welcome assistant)
*[code] Improved message handler API
*Kexi asks for passwords directly on pages without modal dialogs (for New, Open, Welcome assistants) - sample at http://wstaw.org/m/2013/03/01/plasma-desktopZA2566.png
*Improved layout of the context message widget
*Improved support for moving back to previous assistant page

KexiDB
*[code] ConnectionData now "knows" if specifing password is needed for performing connection


This addresses bug 313025.
    http://bugs.kde.org/show_bug.cgi?id=313025


Diffs
-----

  kexi/core/kexi.cpp 087183fcb3786ea795dbdb214b8f27e4517df597 
  kexi/core/kexiguimsghandler.h 50a078f00b65c67da6f38a940cb0d7cc6c0f65a3 
  kexi/core/kexiguimsghandler.cpp 964e561c5f510a9d53c12f18527d8e6a2691376e 
  kexi/core/kexitextmsghandler.h 6c0717fa07530a82bfcb3b5b3f88718e372aed6a 
  kexi/core/kexitextmsghandler.cpp 0001e8a67b1d4458ae1b223845cf9ebf9870c54e 
  kexi/kexiutils/KexiAssistantPage.h 6b494e020fe0f6c7604b8732cc77813830961d9d 
  kexi/kexiutils/KexiAssistantPage.cpp a5f8df7b0d0ed814c8e80a8977ec6c96a0dcc454 
  kexi/kexiutils/KexiAssistantWidget.h 8497b6fc8ce787ab1452764cbc706b2b20b8a383 
  kexi/kexiutils/KexiAssistantWidget.cpp aba01422f08c2fd7ff6eec0a74c996d93152a2a9 
  kexi/kexiutils/KexiContextMessage.cpp b7f533ee82196b21ce23d2cbba6402e8937705a3 
  kexi/kexiutils/kmessagewidget.cpp f4b8ea98811179bc7cebc80367d60b7f87979348 
  kexi/kexiutils/kpassworddialog.ui PRE-CREATION 
  kexi/main/CMakeLists.txt 9d80ac0f7e550aa53744cdcd04bc0ab079860edb 
  kexi/main/KexiMainWindow.cpp 1383610d13b3d5f0d5f5205af42a91a4daff0580 
  kexi/main/startup/KexiAssistantMessageHandler.h PRE-CREATION 
  kexi/main/startup/KexiAssistantMessageHandler.cpp PRE-CREATION 
  kexi/main/startup/KexiImportExportAssistant.h b55d94b67099cf4979f1250ebcadeba93ed6274a 
  kexi/main/startup/KexiImportExportAssistant.cpp 90f87ae4051b61ebabcd2924e9c209a7dab2bf51 
  kexi/main/startup/KexiNewProjectAssistant.h d80fa08993dc603eab3688f38917b39990e9b521 
  kexi/main/startup/KexiNewProjectAssistant.cpp 201a3345bfc48cb3a1f76ed2e0b0b9e703f63a79 
  kexi/main/startup/KexiOpenProjectAssistant.h 599d1ea262b9150cc8f9d504349251a6a51b082a 
  kexi/main/startup/KexiOpenProjectAssistant.cpp 324e7438e0955912d20e590b69c613c050d76180 
  kexi/main/startup/KexiPasswordPage.h PRE-CREATION 
  kexi/main/startup/KexiPasswordPage.cpp PRE-CREATION 
  kexi/main/startup/KexiStartup.h c1807b295d623d1fed1d8dd501d55905d0f7915e 
  kexi/main/startup/KexiStartup.cpp b11bf529efdfd21053b95722060a01342067b7a6 
  kexi/main/startup/KexiWelcomeAssistant.h c5b751bc0f597f7a11c6ae61e26ed618d9edf21a 
  kexi/main/startup/KexiWelcomeAssistant.cpp 4ca9b18946759729ccbf1df6793e84585ad96238 
  kexi/widget/CMakeLists.txt 991c5e62e0e7ac857554709a9bb3110d40f3170d 
  kexi/widget/KexiPasswordWidget.h PRE-CREATION 
  kexi/widget/KexiPasswordWidget.cpp PRE-CREATION 
  kexi/widget/KexiPasswordWidget.ui PRE-CREATION 
  libs/db/connectiondata.h 3bdc0ac9dea7cd6623d7706a8578d8b6739a5b34 
  libs/db/connectiondata.cpp 4c75f5c18a7a5db1568f92a1ea301ce0e8766151 
  libs/db/msghandler.h 4f0faba74520f25f6fba7de2dfd1116478d6ccb6 
  libs/db/msghandler.cpp f575453f7afce43c5641436788cada6fed4174a5 

Diff: http://git.reviewboard.kde.org/r/109214/diff/


Testing
-------

Executed New/Open/Welcome assistants with server connections requiring passowrds, password pages work; tested layouts


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130319/16eaf6d8/attachment.htm>