Review Request 109486: Improved handling of Kexi read-only mode

[Oleg Kukharchuk]

> On March 18, 2013, 8:15 p.m., Oleg Kukharchuk wrote:
> > may be it's better to disable DesignMode for forms when the database opened in read only?
> 
> Jarosław Staniek wrote:
>     Thanks for the review. 
>     
>     Enabling Design mode is explicitly by design - I thought about it quite a bit. The point is to let users:
>     - to copy parts of the design and paste into a new project's form, or
>     - to study how the forms are constructed
>     
>     I see no reason to stop people from doing that (just like they can actually read their read-only text files).
>     
>     Does this convince you? :)

yep)


- Oleg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109486/#review29468
-----------------------------------------------------------


On March 18, 2013, 8:43 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109486/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 8:43 p.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, and Radosław Wicik.
> 
> 
> Description
> -------
> 
> Improved handling of Kexi read-only mode
> 
> Main Window
> *Improved messages when opening read-only projects
> *Fixed opening projects as read-only
> *Added proposing opening read-only for projects that cannot be open read-write
> *Added "(read only)" string to the window title to indicate read-only mode
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexiproject.h 11afb4fb7751c9a806387e6f6409a8570520bcc1 
>   kexi/core/kexiproject.cpp 20c82aceff5a9be48a22f51c6052e913034a17f0 
>   kexi/main/KexiMainWindow.cpp 1383610d13b3d5f0d5f5205af42a91a4daff0580 
>   kexi/main/startup/KexiStartup.h c1807b295d623d1fed1d8dd501d55905d0f7915e 
>   kexi/main/startup/KexiStartup.cpp b11bf529efdfd21053b95722060a01342067b7a6 
> 
> Diff: http://git.reviewboard.kde.org/r/109486/diff/
> 
> 
> Testing
> -------
> 
> Opened read-only files, tested the readonly option
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130318/591d0e73/attachment.htm>