Review Request 109508: Added scrollbar to shape-handling in order to restrict its expansion beyond limit

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109508/#review29358
-----------------------------------------------------------

Ship it!


when you have fixed my remaining issue, you are free to push.

thanks


libs/main/KoModeBox.cpp
<http://git.reviewboard.kde.org/r/109508/#comment21944>

    setFrameShape(QFrame::NoFrame)
    
    just setting shadow to plain will not be enough on all styles


- C. Boemann


On March 17, 2013, 6:38 a.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109508/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 6:38 a.m.)
> 
> 
> Review request for Calligra, C. Boemann and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> Bug 316469 - Window stretches down when Shape Handling is clicked in Calligrawords and Calligrasheets.
> Added scrollArea to widget to restrict expansion of shape-handling beyond limit.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoModeBox.cpp dde9aff 
> 
> Diff: http://git.reviewboard.kde.org/r/109508/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me.
> 
> 
> File Attachments
> ----------------
> 
> Original Bug
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/16/Calligra.png
> Stretched look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/16/Calligra1.png
> Normal View
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/16/Calligra2.png
> Shrunken View
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/16/Calligra3.png
> 
> 
> Thanks,
> 
> Sudhendu Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130317/c65c6ed2/attachment.htm>