Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

[Marijn Kruisselbrink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109378/#review28882
-----------------------------------------------------------


looks mostly good, a couple of small nits left


sheets/ui/CellToolBase.cpp
<http://git.reviewboard.kde.org/r/109378/#comment21612>

    whitespace around == and before ( here and in the other line, so:
    if (event->key() == Qt::Key_F2)
    Then shouldn't Qt_Delete be Qt::Key_Delete?
    and please no tab-characters as whitespace before the comments, use spaces instead.


- Marijn Kruisselbrink


On March 10, 2013, 1:39 p.m., Jigar Raisinghani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109378/
> -----------------------------------------------------------
> 
> (Updated March 10, 2013, 1:39 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> KAction does not support function keys(F1,F2 etc) as shortCuts. QAction does but KoToolBase does not allow for both KAction* & QAction* at the same time. 
> Added an exception for F2 as needed. 
> 
> Fixed. 
> 
> 
> This addresses bug 291624.
>     http://bugs.kde.org/show_bug.cgi?id=291624
> 
> 
> Diffs
> -----
> 
>   sheets/ui/CellToolBase.cpp e66ba5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109378/diff/
> 
> 
> Testing
> -------
> 
> Yes, working.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130310/3ed9a806/attachment.htm>